Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1849518: [release-4.4] show the source commit id #292

Merged
merged 2 commits into from Jun 25, 2020
Merged

Bug 1849518: [release-4.4] show the source commit id #292

merged 2 commits into from Jun 25, 2020

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #288

/assign kevinrizza

@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.4] show the source commit id

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 16, 2020
Merged
5 tasks
@jianzhangbjz
Copy link
Contributor

/retest

@kevinrizza
Copy link
Member

@jianzhangbjz fyi you need to clone the bug to target 4.4.z and update the pr title to reference that clone or the automation won't allow it to merge.

@kevinrizza
Copy link
Member

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kevinrizza, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2020
@jianzhangbjz
Copy link
Contributor

/retest

@jianzhangbjz
Copy link
Contributor

@kevinrizza Thanks! I created a bug https://bugzilla.redhat.com/show_bug.cgi?id=1849518 for it and modified the original PR's title. But, I couldn't modify this PR's since I'm not the owner. Could you help add the bugzilla/valid-bug label manually? Or what else I should do? Thanks!

@kevinrizza
Copy link
Member

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@kevinrizza: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jianzhangbjz
Copy link
Contributor

jianzhangbjz commented Jun 24, 2020 •
edited

@ecordell Could you help add the bugzilla/valid-bug and cherry-pick-approved labels manually? Thanks!

image

@jianzhangbjz
Copy link
Contributor

/lgtm

@openshift-ci-robot
Copy link
Contributor

@jianzhangbjz: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jianzhangbjz
Copy link
Contributor

@kevinrizza I guess it needs the /lgtm label, thanks!

@jianzhangbjz
Copy link
Contributor

@kevinrizza @ecordell Or could you help update this PR's title? Thanks! I don't have the edit permission.

@exdx
Copy link
Member

exdx commented Jun 25, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 25, 2020
@exdx exdx changed the title [release-4.4] show the source commit id Bug 1849518: [release-4.4] show the source commit id Jun 25, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Jun 25, 2020
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1849518, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.4.z) matches configured target release for branch (4.4.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1849524 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1849524 targets the "4.5.0" release, which is one of the valid target releases: 4.5.0, 4.5.z
  • bug has dependents

In response to this:

Bug 1849518: [release-4.4] show the source commit id

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jun 25, 2020
@shawn-hurley shawn-hurley added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 25, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 34fd70b into operator-framework:release-4.4 Jun 25, 2020
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged: operator-framework/operator-marketplace#292. Bugzilla bug 1849518 has been moved to the MODIFIED state.

In response to this:

Bug 1849518: [release-4.4] show the source commit id

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecordell ecordell Awaiting requested review from ecordell

@kevinrizza kevinrizza Awaiting requested review from kevinrizza

Assignees

@kevinrizza kevinrizza

@exdx exdx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@openshift-cherrypick-robot @openshift-ci-robot @jianzhangbjz @kevinrizza @exdx @openshift-bot @shawn-hurley @openshift-merge-robot @benluddy