[operatorhub] Accept CatalogSource as a default source #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
do-not-merge/work-in-progress
anik120
force-pushed
the
operatorhub-accpet-catsrc
branch
2 times, most recently
from
c9c852a
to
cd7a436
Compare
|
/test e2e-aws-console-olm |
anik120
force-pushed
the
operatorhub-accpet-catsrc
branch
from
cd7a436
to
3fb15b9
Compare
anik120
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
ecordell
reviewed
Apr 13, 2020
pkg/defaults/catsrcHelpers.go
Outdated
| strings.EqualFold(spec1.Address, spec2.Address) && | ||
| strings.EqualFold(spec1.DisplayName, spec2.DisplayName) && | ||
| strings.EqualFold(spec1.Publisher, spec2.Publisher) && | ||
| strings.EqualFold(spec1.Image, spec2.Image) { |
There was a problem hiding this comment.
This should probably include the updatestrategy as well (updateStrategy.pollInterval IIRC), so that we can update the default polling on these images
There was a problem hiding this comment.
@ecordell addressed
kevinrizza
approved these changes
Apr 13, 2020
pkg/defaults/catsrcHelpers.go
Outdated
| ) | ||
|
|
||
| func ensureCatsrc(client wrapper.Client, config map[string]bool, catsrc olm.CatalogSource) error { | ||
|
|
There was a problem hiding this comment.
super nit: this space is not in style
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anik120, kevinrizza The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
anik120
force-pushed
the
operatorhub-accpet-catsrc
branch
from
3fb15b9
to
85b94cd
Compare
|
/lgtm |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
anik120
force-pushed
the
operatorhub-accpet-catsrc
branch
from
85b94cd
to
e57f16a
Compare
Updates OLM to 0.14.1
This PR enhances the OperatorHub API's capablity to accept a CatalogSource as a default source along with OperatorSource.
anik120
force-pushed
the
operatorhub-accpet-catsrc
branch
from
e57f16a
to
df1d951
Compare
|
/lgtm |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
anik120
added a commit
to anik120/operator-marketplace
that referenced
this pull request
May 6, 2020
In operator-framework#300, the OperatorHub API was enhanced to accept both OperatorSource and CatalogSource as defaults. However, when an existing OperatorSource in a cluster was switched to a CatalogSource, the old OperatorSource persisted. This PR fixes the issue, and removes the obsolete OperatorSource, so that there's only one source for a catalog of operators.
anik120
added a commit
to anik120/operator-marketplace
that referenced
this pull request
May 6, 2020
In operator-framework#300, the OperatorHub API was enhanced to accept both OperatorSource and CatalogSource as defaults. However, when an existing OperatorSource in a cluster was switched to a CatalogSource, the old OperatorSource persisted. This PR fixes the issue, and removes the obsolete OperatorSource, so that there's only one source for a catalog of operators.
5 tasks
anik120
added a commit
to anik120/operator-marketplace
that referenced
this pull request
May 8, 2020
In operator-framework#300, the OperatorHub API was enhanced to accept both OperatorSource and CatalogSource as defaults. However, when an existing OperatorSource in a cluster was switched to a CatalogSource, the old OperatorSource persisted. This PR fixes the issue, and removes the obsolete OperatorSource, so that there's only one source for a catalog of operators.
anik120
added a commit
to anik120/operator-marketplace
that referenced
this pull request
May 8, 2020
In operator-framework#300, the OperatorHub API was enhanced to accept both OperatorSource and CatalogSource as defaults. However, when an existing OperatorSource in a cluster was switched to a CatalogSource, the old OperatorSource persisted. This PR fixes the issue, and removes the obsolete OperatorSource, so that there's only one source for a catalog of operators.
anik120
added a commit
to anik120/operator-marketplace
that referenced
this pull request
May 8, 2020
In operator-framework#300, the OperatorHub API was enhanced to accept both OperatorSource and CatalogSource as defaults. However, when an existing OperatorSource in a cluster was switched to a CatalogSource, the old OperatorSource persisted. This PR fixes the issue, and removes the obsolete OperatorSource, so that there's only one source for a catalog of operators.
anik120
added a commit
to anik120/operator-marketplace
that referenced
this pull request
May 8, 2020
In operator-framework#300, the OperatorHub API was enhanced to accept both OperatorSource and CatalogSource as defaults. However, when an existing OperatorSource in a cluster was switched to a CatalogSource, the old OperatorSource persisted. This PR fixes the issue, and removes the obsolete OperatorSource, so that there's only one source for a catalog of operators.
anik120
added a commit
to anik120/operator-marketplace
that referenced
this pull request
May 8, 2020
In operator-framework#300, the OperatorHub API was enhanced to accept both OperatorSource and CatalogSource as defaults. However, when an existing OperatorSource in a cluster was switched to a CatalogSource, the old OperatorSource persisted. This PR fixes the issue, and removes the obsolete OperatorSource, so that there's only one source for a catalog of operators.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
This PR enhances the OperatorHub API's capablity to accept a
CatalogSource as a default source along with OperatorSource.
Motivation for the change:
In Openshift 4.5, we want to be able to support both OperatorSources
and CatalogSources as default source types.
Reviewer Checklist
/docs