Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[default] Switch default OperatorSources to CatalogSources #318

Merged
merged 1 commit into from Aug 3, 2020
Merged

[default] Switch default OperatorSources to CatalogSources #318

merged 1 commit into from Aug 3, 2020

Conversation

anik120
Copy link
Contributor

@anik120 anik120 commented Jul 15, 2020

Description of the change:

This PR switches the default OperatorSources to CatalogSources.

Motivation for the change:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

shawn-hurley
shawn-hurley reviewed Jul 22, 2020
View reviewed changes
defaults/03_community_operators.yaml Outdated
endpoint: "https://quay.io/cnr"
registryNamespace: "community-operators"
sourceType: grpc
image: registry.redhat.io/redhat/community-operator-index:v4.6
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that we are changing this:

quay.io/openshift-community-operators/catalog:latest

@shawn-hurley
Copy link
Member

/retest

kevinrizza
kevinrizza requested changes Jul 22, 2020
View reviewed changes
Copy link
Member

@kevinrizza kevinrizza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is the last bit that actually could allow an operator source onto the cluster, shouldn't this pr also fully remove that API entirely?

@kevinrizza
Copy link
Member

/retest

@anik120
Copy link
Contributor Author

anik120 commented Jul 27, 2020

/retest

@anik120
Copy link
Contributor Author

anik120 commented Jul 28, 2020

/hold
Blocked by operator-framework/operator-lifecycle-manager#1682

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 28, 2020
@anik120
Copy link
Contributor Author

anik120 commented Jul 30, 2020

/hold cancel

Not adding the priority field to CatalogSources for this PR.

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 30, 2020
@kevinrizza
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 30, 2020
@anik120
Copy link
Contributor Author

anik120 commented Jul 30, 2020

/hold
Waiting for operator-marketplace image to become available.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 30, 2020
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2020
@ecordell
Copy link
Member

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 31, 2020
@ecordell
Copy link
Member

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anik120, ecordell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2020
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2020
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 1, 2020
@anik120
Copy link
Contributor Author

anik120 commented Aug 2, 2020

/retest

@anik120
[default] Switch default OperatorSources to CatalogSources
2033788 
This PR switches the default OperatorSources to CatalogSources.
@anik120
Copy link
Contributor Author

anik120 commented Aug 3, 2020

/test e2e-aws-upgrade

@ecordell
Copy link
Member

ecordell commented Aug 3, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 3, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 2840de4 into operator-framework:master Aug 3, 2020
anik120 added a commit to anik120/operator-marketplace that referenced this pull request Aug 10, 2020
@anik120
Bug 1867821: Include spec.priority for default sources
f1adac5 
This PR ranks the default catalogsources in order of prefered
catalog introduced in operator-framework#318
@anik120 anik120 mentioned this pull request Aug 10, 2020
Closed
5 tasks
anik120 added a commit to anik120/operator-marketplace that referenced this pull request Aug 12, 2020
@anik120
Bug 1867821: Include spec.priority for default sources
8dba8e2 
This PR ranks the default catalogsources in order of prefered
catalog introduced in operator-framework#318
anik120 added a commit to anik120/operator-marketplace that referenced this pull request Aug 12, 2020
@anik120
Bug 1867821: Include spec.priority for default sources
dd17c50 
This PR ranks the default catalogsources in order of prefered
catalog introduced in operator-framework#318
anik120 added a commit to anik120/operator-marketplace that referenced this pull request Aug 21, 2020
@anik120
Bug 1867821: Include spec.priority for default sources
30a30b6 
This PR ranks the default catalogsources in order of prefered
catalog introduced in operator-framework#318
@anik120 anik120 mentioned this pull request Aug 21, 2020
Merged
5 tasks
anik120 added a commit to anik120/operator-marketplace that referenced this pull request Aug 21, 2020
@anik120
Bug 1867821: Include spec.priority for default sources
657f248 
This PR ranks the default catalogsources in order of prefered
catalog introduced in operator-framework#318
anik120 added a commit to anik120/operator-marketplace that referenced this pull request Aug 21, 2020
@anik120
Bug 1867821: Include spec.priority for default sources
8cce859 
This PR ranks the default catalogsources in order of prefered
catalog introduced in operator-framework#318
anik120 added a commit to anik120/operator-marketplace that referenced this pull request Aug 21, 2020
@anik120
Bug 1867821: Include spec.priority for default sources
3bb5392 
This PR ranks the default catalogsources in order of prefered
catalog introduced in operator-framework#318
anik120 added a commit to anik120/operator-marketplace that referenced this pull request Aug 21, 2020
@anik120
Bug 1867821: Include spec.priority for default sources
d87a8eb 
This PR ranks the default catalogsources in order of prefered
catalog introduced in operator-framework#318
anik120 added a commit to anik120/operator-marketplace that referenced this pull request Aug 21, 2020
@anik120
Bug 1867821: Include spec.priority for default sources
31634d7 
This PR ranks the default catalogsources in order of prefered
catalog introduced in operator-framework#318
anik120 added a commit to anik120/operator-marketplace that referenced this pull request Aug 25, 2020
@anik120
Bug 1867821: Include spec.priority for default sources
2ca5636 
This PR ranks the default catalogsources in order of prefered
catalog introduced in operator-framework#318
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecordell ecordell ecordell left review comments

@shawn-hurley shawn-hurley shawn-hurley left review comments

@kevinrizza kevinrizza kevinrizza requested changes

@Bowenislandsong Bowenislandsong Awaiting requested review from Bowenislandsong

Assignees

@ecordell ecordell

@kevinrizza kevinrizza

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@anik120 @shawn-hurley @kevinrizza @ecordell @openshift-ci-robot @openshift-bot @openshift-merge-robot