Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix upstream deployment #342

Merged
merged 1 commit into from Dec 6, 2020
Merged

Fix upstream deployment #342

merged 1 commit into from Dec 6, 2020

Conversation

awgreene
Copy link
Member

Problem: The registryServerImage runtime argument was recently removed
from marketplace but the marketplace deployment defined for the upstream
build did not remove the argument which caused the upstream marketplace
pod to crash.

Solution: Update the deployment manifest so it does not include the
registryServerImage runtime argument.

@awgreene
Fix upstream deployment
66d8449 
Problem: The `registryServerImage` runtime argument was recently removed
from marketplace but the marketplace deployment defined for the upstream
build did not remove the argument which caused the upstream marketplace
pod to crash.

Solution: Update the deployment manifest so it does not include the
`registryServerImage` runtime argument.
@awgreene
Copy link
Member Author

/retest

@ukclivecox
Copy link

Any reason this is not being merged? @awgreene

@ukclivecox ukclivecox mentioned this pull request Oct 10, 2020
Closed
@anik120
Copy link
Contributor

anik120 commented Nov 12, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 12, 2020
@ryandawsonuk
Copy link

@kevinrizza would you be able to approve this?

@kevinrizza
Copy link
Member

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awgreene, kevinrizza

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit ca70ae8 into operator-framework:master Dec 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anik120 anik120 Awaiting requested review from anik120

@ankitathomas ankitathomas Awaiting requested review from ankitathomas

Assignees

@anik120 anik120

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@awgreene @ukclivecox @anik120 @ryandawsonuk @kevinrizza @openshift-ci-robot @openshift-bot @openshift-merge-robot