New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd,pkg: Remove migration logic for deprecated APIs #412
cmd,pkg: Remove migration logic for deprecated APIs #412
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this @timflannagan it was long overdue. Looks good to me so far, we can also remove pkg/migrator
as part of this PR after that I can lgtm it.
6573c4a
to
6616e86
Compare
Update the cmd,pkg files that house the cleanup/migration logic for ensuring that any deprecated APIs, like the OperatorSource resource, are transistioned to the CatalogSource resource. These APIs have been deprecated for multiple OCP releases now, and the marketplace project is largely a downstream project at this point as most of the heavy-lifting functionality has been migrated over to upstream OLM, so these changes should help cleanup the main package.
6616e86
to
100426f
Compare
/retest |
1 similar comment
/retest |
/retest |
/approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anik120, kevinrizza, timflannagan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/test e2e-aws-upgrade |
/retest Please review the full test history for this PR and help us cut down flakes. |
4 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
5 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/hold |
/retest |
Update the cmd,pkg files that house the cleanup/migration logic for
ensuring that any deprecated APIs, like the OperatorSource resource, are
transistioned to the CatalogSource resource. These APIs have been
deprecated for multiple OCP releases now, and the marketplace project is
largely a downstream project at this point as most of the heavy-lifting
functionality has been migrated over to upstream OLM, so these changes
should help cleanup the main package.
Description of the change:
Motivation for the change:
Reviewer Checklist
/docs