Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.3] bug 1763303: Fix handling of AdditionalArtifactKeys in AWS billing report manifests #1029

Merged
merged 2 commits into from Nov 16, 2019
Merged

[release-4.3] bug 1763303: Fix handling of AdditionalArtifactKeys in AWS billing report manifests #1029

merged 2 commits into from Nov 16, 2019

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #1027

/assign chancez

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 13, 2019
Merged
@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Nov 13, 2019
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1763303, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

[release-4.3] bug 1763303: Fix handling of AdditionalArtifactKeys in AWS billing report manifests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 13, 2019
@openshift-ci-robot
Copy link

Hi @openshift-cherrypick-robot. Thanks for your PR.

I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 13, 2019
@chancez
Copy link
Contributor

chancez commented Nov 13, 2019

/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 13, 2019
@chancez chancez added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Nov 14, 2019
@chancez
Copy link
Contributor

chancez commented Nov 14, 2019

Adding the cherry-pick approved label since this is to 4.3 and 4.3 is still open for bugs (we simply aren't FFing our master to 4.3 anymore, hence the cherry-pick)

@chancez
Copy link
Contributor

chancez commented Nov 15, 2019

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chancez, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 15, 2019
@chancez
Copy link
Contributor

chancez commented Nov 15, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 15, 2019
@chancez
Copy link
Contributor

chancez commented Nov 15, 2019

/retest

@openshift-merge-robot openshift-merge-robot merged commit ea34247 into kube-reporting:release-4.3 Nov 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chancez chancez Awaiting requested review from chancez

@bentito bentito Awaiting requested review from bentito

@timflannagan timflannagan Awaiting requested review from timflannagan

Assignees

@chancez chancez

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@openshift-cherrypick-robot @openshift-ci-robot @chancez @openshift-merge-robot