bug 1757547: charts/openshift-metering: Update cpu/memory usage promqueries to handle many to many matching error #958
Conversation
openshift-ci-robot
added
approved
chancez
force-pushed
the
fix_metrics_import_many_to_many
branch
from
f7195ff
to
33cf322
Compare
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
|
This PR and others are blocked until #960 merges |
These queries were returning many to many matching errors on the group_left that I didn't end up diagnosing, but I discovered we can remove it since the container level metrics got the node name field that we were joining from kube_pod_info. This simplifies them overall. Additionally, I bumped up the window size for when we take the rate of the CPU. Also updates CPU usage query to use a 5 minute window instead of 1 minute for better accuracy and alignment with upstreams values.
chancez
force-pushed
the
fix_metrics_import_many_to_many
branch
from
33cf322
to
2a070e0
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chancez, timflannagan1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
chancez
changed the title
openshift-ci-robot
added
the
bugzilla/invalid-bug
|
@chancez: This pull request references Bugzilla bug 1757547, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
|
@chancez: This pull request references Bugzilla bug 1757547, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
bugzilla/valid-bug
|
/cherry-pick release-4.2 |
|
@chancez: once the present PR merges, I will cherry-pick it on top of release-4.2 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
@chancez: All pull requests linked via external trackers have merged. Bugzilla bug 1757547 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@chancez: #958 failed to apply on top of branch "release-4.2": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
These queries were returning many to many matching errors on the
group_left that I didn't end up diagnosing, but I discovered we can
remove it since the container level metrics got the node name field that
we were joining from kube_pod_info. This simplifies them overall.
Additionally, I bumped up the window size for when we take the rate of
the CPU.