Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating owners #1058

Merged

Conversation

grokspawn
Copy link
Contributor

Signed-off-by: Jordan jordan@nimblewidget.com

Description of the change:

Motivation for the change:
culling old / adding leads, ecosystem team members

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2023
@awgreene
Copy link
Member

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awgreene, grokspawn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Jan 20, 2023
@codecov
Copy link

codecov bot commented Jan 20, 2023

Codecov Report

Merging #1058 (e96f1a3) into master (0080ea0) will increase coverage by 0.82%.
The diff coverage is 93.54%.

❗ Current head e96f1a3 differs from pull request most recent head bd87fad. Consider uploading reports for the commit bd87fad to get more accurate results

@@            Coverage Diff             @@
##           master    #1058      +/-   ##
==========================================
+ Coverage   52.06%   52.88%   +0.82%     
==========================================
  Files         102      104       +2     
  Lines        9218     9403     +185     
==========================================
+ Hits         4799     4973     +174     
- Misses       3505     3514       +9     
- Partials      914      916       +2     
Impacted Files Coverage Δ
alpha/declcfg/load.go 76.52% <70.37%> (-2.13%) ⬇️
alpha/veneer/composite/builder.go 97.20% <97.20%> (ø)
alpha/veneer/composite/composite.go 100.00% <100.00%> (ø)
alpha/veneer/semver/semver.go 65.02% <0.00%> (+0.49%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Jordan <jordan@nimblewidget.com>
@openshift-ci openshift-ci bot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Jan 20, 2023
@oceanc80
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2023
@openshift-merge-robot openshift-merge-robot merged commit 25a478d into operator-framework:master Jan 20, 2023
@grokspawn grokspawn deleted the update-owners branch January 20, 2023 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants