use mount flag to force consistent selinux labelling between host/guest on generated files #1060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st on generated files Signed-off-by: Jordan <jordan@nimblewidget.com>
openshift-ci
bot
added
the
approved
Codecov Report
@@ Coverage Diff @@
## master #1060 +/- ##
==========================================
+ Coverage 52.74% 52.76% +0.02%
==========================================
Files 106 106
Lines 9375 9375
==========================================
+ Hits 4945 4947 +2
+ Misses 3517 3515 -2
Partials 913 913
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
everettraven
approved these changes
Jan 26, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: everettraven, grokspawn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jordan jordan@nimblewidget.com
Description of the change:
Motivation for the change:
without this flag, there is inconsistent labeling between intermediate composite template products on the host and the container which will (read-only) access them.
When selinux is in enforcing mode, these steps will fail to execute.
For more info, https://projectatomic.io/blog/2015/06/using-volumes-with-docker-can-cause-problems-with-selinux/
Reviewer Checklist
/docs