Package sort for deterministic ordering in ListBundles API #1084
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
openshift-ci
bot
added
the
approved
Codecov Report
@@ Coverage Diff @@
## master #1084 +/- ##
==========================================
+ Coverage 52.57% 52.61% +0.03%
==========================================
Files 107 107
Lines 9384 9389 +5
==========================================
+ Hits 4934 4940 +6
+ Misses 3523 3522 -1
Partials 927 927
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
| @@ -34,6 +35,7 @@ func (pkgs packageIndex) GetPackage(_ context.Context, name string) (*registry.P | |||
| CurrentCSVName: ch.Head, | |||
| }) | |||
| } | |||
| sort.Slice(channels, func(i, j int) bool { return strings.Compare(channels[i].Name, channels[j].Name) < 0 }) | |||
There was a problem hiding this comment.
This come up in a different conversation somewhere didn't it? Did we never fix this?
There was a problem hiding this comment.
Maybe you're thinking of operator-lifecycle-manager/pull/2925 ?
Signed-off-by: Jordan Keister <jordan@nimblewidget.com>
Signed-off-by: Jordan Keister <jordan@nimblewidget.com>
Signed-off-by: Jordan Keister <jordan@nimblewidget.com>
Signed-off-by: Jordan Keister <jordan@nimblewidget.com>
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: grokspawn, tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…framework#1084) * impose order on maps Signed-off-by: Jordan Keister <jordan@nimblewidget.com> * now modding GetBundle Signed-off-by: Jordan Keister <jordan@nimblewidget.com> * more terse Signed-off-by: Jordan Keister <jordan@nimblewidget.com> * forgot bundles Signed-off-by: Jordan Keister <jordan@nimblewidget.com> --------- Signed-off-by: Jordan Keister <jordan@nimblewidget.com>
Description of the change:
Motivation for the change:
solves #1069
Reviewer Checklist
/docs