Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace github.com/ghodss/yaml with sigs.k8s.io/yaml #1171

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Replace github.com/ghodss/yaml with sigs.k8s.io/yaml #1171

merged 1 commit into from
Dec 4, 2023

Conversation

Juneezee
Copy link
Contributor

Description of the change:

A follow-up of PR operator-framework/api#308. The github.com/ghodss/yaml package is no longer actively maintained. sigs.k8s.io/yaml is a permanent fork of github.com/ghodss/yaml, which is currently maintained by Kubernetes SIG.

Motivation for the change:

Remove an obsolete dependency

Reviewer Checklist

  • [ ] Implementation matches the proposed design, or proposal is updated to match implementation
  • [ ] Sufficient unit test coverage
  • [ ] Sufficient end-to-end test coverage
  • [ ] Docs updated or added to /docs
  • Commit messages sensible and descriptive

At the time of making this commit, the package `github.com/ghodss/yaml`
is no longer actively maintained.

`sigs.k8s.io/yaml` is a permanent fork of `ghodss/yaml` and is actively
maintained by Kubernetes SIG.

Reference: operator-framework/api#308
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 29, 2023
Copy link
Contributor

openshift-ci bot commented Nov 29, 2023

Hi @Juneezee. Thanks for your PR.

I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Juneezee
Copy link
Contributor Author

Juneezee commented Dec 1, 2023

/auto-cc

@stevekuznetsov
Copy link
Member

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 4, 2023
Copy link
Contributor

openshift-ci bot commented Dec 4, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Juneezee, stevekuznetsov
Once this PR has been reviewed and has the lgtm label, please assign perdasilva for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stevekuznetsov stevekuznetsov merged commit 6df3aba into operator-framework:master Dec 4, 2023
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants