Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating operator-framework/api dependency which has k8s 1.28 changes #1189

Conversation

acornett21
Copy link
Contributor

Description of the change:
Updating dependencies to support k8s 1.28.

Motivation for the change:
To stay current with dependencies.

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

@openshift-ci openshift-ci bot requested review from njhale and oceanc80 January 9, 2024 22:08
Copy link
Contributor

openshift-ci bot commented Jan 9, 2024

Hi @acornett21. Thanks for your PR.

I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 9, 2024
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6fd8cec) 53.79% compared to head (445abf6) 53.79%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1189   +/-   ##
=======================================
  Coverage   53.79%   53.79%           
=======================================
  Files         108      108           
  Lines       10367    10367           
=======================================
  Hits         5577     5577           
  Misses       3808     3808           
  Partials      982      982           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acornett21 acornett21 force-pushed the update_operator_framework_api branch from 87afe23 to 5b19a88 Compare January 9, 2024 22:18
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 9, 2024
@joelanford
Copy link
Member

/hold

I'd like to get any remaining dep bumps into the operator-framework/api repo, then cut a release. That way we, we can pin to a tag here rather than a commit.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 10, 2024
@joelanford
Copy link
Member

@acornett21 I tagged https://github.com/operator-framework/api/releases/tag/v0.21.0. Can you update this PR to use that?

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 10, 2024
Signed-off-by: Adam D. Cornett <adc@redhat.com>
@acornett21
Copy link
Contributor Author

@joelanford Thanks for cutting the release. I updated to the release version.

@joelanford
Copy link
Member

/hold cancel
/lgtm
/approve

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 10, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2024
Copy link
Contributor

openshift-ci bot commented Jan 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: acornett21, joelanford

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 087f3c5 into operator-framework:master Jan 10, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants