Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix codecov-action params #1361

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Conversation

m1kola
Copy link
Member

@m1kola m1kola commented Jun 20, 2024

Description of the change:

  • functionalities param is no longer exist. It was used to enable file fixes to ignore common lines from coverage. This feature is now seems to be on by default.

  • Adding disable_search because we do not need for the codecov action to search for coverage files: we explicitly provide files.

Motivation for the change:

Fixing codecov config.

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

* `functionalities` param is no longer exist.
  It was used to enable file fixes to ignore common lines from coverage.
  This feature is now seems to be on by default.

* Adding `disable_search` because we do not need for the codecov action
  to search for coverage files: we explicitly provide files.

Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
Copy link
Contributor

openshift-ci bot commented Jun 20, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: m1kola
Once this PR has been reviewed and has the lgtm label, please assign njhale for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.35%. Comparing base (69e2e46) to head (cd2b54d).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1361      +/-   ##
==========================================
- Coverage   48.36%   48.35%   -0.01%     
==========================================
  Files         133      133              
  Lines       12693    12693              
==========================================
- Hits         6139     6138       -1     
- Misses       5516     5517       +1     
  Partials     1038     1038              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@m1kola m1kola added this pull request to the merge queue Jun 20, 2024
Merged via the queue into operator-framework:master with commit 6bddca8 Jun 20, 2024
11 of 12 checks passed
@m1kola m1kola deleted the codecov_fixes branch June 20, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant