Add support for choosing the release of a package

[gbenhaim]

Description of the change:

This change adds the possibility to specify the requested release after
the package's name (e.g "Kubevirt:10.0.0"). If the version is not specified,
the server will download the latest version from the appregistry.

Motivation for the change:

Up until now, the appregistry-server always pulled the latest
version of the requested packages, which makes sense for production,
but not for testing and release phases of the packages.

During testing, multiple version of the same package can be
tested at the same time, and when releasing, it's not mandatory
that the different releases will be released on the same date.

When combining the appregistry-server logic, with the properties of the
test and release phases, there is a need to create a complex automation
for merging multiple versions (so they can be tested at the time) into
a single bundle, and omitting non-ready releases from bundles,
after testing and before the release.

Depends on #139

Reviewer Checklist

• Implementation matches the proposed design, or proposal is updated to match implementation
• Sufficient unit test coverage
• Sufficient end-to-end test coverage
• Docs updated or added to /docs
• Commit messages sensible and descriptive

[openshift-ci-robot]

Hi @gbenhaim. Thanks for your PR.

I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[gbenhaim]

/assign @jpeeler

[njhale]

/ok-to-test

[njhale]

/retest

[gbenhaim]

/hold
The list of packages doesn't appear as expected in the log, I'll fix it.

[gbenhaim]

/retest

[gbenhaim]

CI Issue

Installing from release registry.svc.ci.openshift.org/ci-op-bkr8ndcn/release@sha256:aa62ded914897f6572377fe20883d83b9c5b4c3dfa4d6e3ba82af84f2e380e05
level=info msg="Credentials loaded from the \"default\" profile in file \"/etc/openshift-installer/.awscred\""
level=warning msg="Found override for release image. Please be warned, this is not advised"
level=info msg="Consuming Install Config from target directory"
level=info msg="Creating infrastructure resources..."
level=error
level=error msg="Error: Error waiting for AMI (ami-0d65912c61e50db4a) to be ready: timeout while waiting for state to become 'available' (last state: 'pending', timeout: 40m0s)"
level=error
level=error msg="  on ../tmp/openshift-install-178706324/main.tf line 104, in resource \"aws_ami_copy\" \"main\":"
level=error msg=" 104: resource \"aws_ami_copy\" \"main\" {"
level=error
level=error
level=fatal msg="failed to fetch Cluster: failed to generate asset \"Cluster\": failed to create cluster: failed to apply using Terraform"

[gbenhaim]

/test e2e-aws

[gbenhaim]

/retest

[fabiand]

/retest

[gbenhaim]

Looks like CI failed multiple times while trying to bootstrap a cluster, specifficaly when trying to allocate AWS resources:

https://storage.googleapis.com/origin-ci-test/pr-logs/pull/operator-framework_operator-registry/141/pull-ci-operator-framework-operator-registry-master-e2e-aws/479/artifacts/e2e-aws/container-logs/setup.log

Installing from release registry.svc.ci.openshift.org/ci-op-90wsrkg3/release@sha256:0c10bcf8748b63a47720174467e93b8599c8ec2f7ba1b6d7ec4fb01bd33abb22
level=info msg="Credentials loaded from the \"default\" profile in file \"/etc/openshift-installer/.awscred\""
level=warning msg="Found override for release image. Please be warned, this is not advised"
level=info msg="Consuming Install Config from target directory"
level=info msg="Creating infrastructure resources..."
level=error
level=error msg="Error: Error creating NAT Gateway: NatGatewayLimitExceeded: Performing this operation would exceed the limit of 200 NAT gateways"
level=error msg="\tstatus code: 400, request id: 18330325-ba57-40be-a151-500aa4f11428"
level=error
level=error msg="  on ../tmp/openshift-install-247850634/vpc/vpc-public.tf line 85, in resource \"aws_nat_gateway\" \"nat_gw\":"
level=error msg="  85: resource \"aws_nat_gateway\" \"nat_gw\" {"
level=error
level=error
level=error
level=error msg="Error: Error creating NAT Gateway: NatGatewayLimitExceeded: Performing this operation would exceed the limit of 200 NAT gateways"
level=error msg="\tstatus code: 400, request id: 564fbfc0-6030-4e13-9297-5ce6e5cc482f"
level=error
level=error msg="  on ../tmp/openshift-install-247850634/vpc/vpc-public.tf line 85, in resource \"aws_nat_gateway\" \"nat_gw\":"
level=error msg="  85: resource \"aws_nat_gateway\" \"nat_gw\" {"
level=error
level=error
level=fatal msg="failed to fetch Cluster: failed to generate asset \"Cluster\": failed to create cluster: failed to apply using Terraform"

[gbenhaim]

/test e2e-aws

[gbenhaim]

/unhold

[gbenhaim]

This one is ready.
There are 5 tests that fail because of issues that are unrelated to this change.

[gbenhaim]

@njhale @jpeeler Hi guys, can you please take a look on this PR?

[jpeeler]

/retest

[jpeeler]

/retest

[jpeeler]

/retest

[jpeeler]

/retest

[jpeeler]

/lgtm

[jpeeler]

/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gbenhaim, jpeeler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jpeeler]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[gbenhaim]

@jpeeler Thanks a lot!