Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1795658: Remove dependency on sqlite from pkg/configmap. #161

Merged
merged 1 commit into from Jan 29, 2020
Merged

Bug 1795658: Remove dependency on sqlite from pkg/configmap. #161

merged 1 commit into from Jan 29, 2020

Conversation

benluddy
Copy link
Contributor

The package github.com/mattn/go-sqlite3 needs CGO enabled to
build. Since pkg/configmap has both direct and transitive dependencies
on go-sqlite3, anything importing pkg/configmap will also need to
enable CGO.

@benluddy
Remove dependency on sqlite from pkg/configmap.
78107d4 
The package github.com/mattn/go-sqlite3 needs CGO enabled to
build. Since pkg/configmap has both direct and transitive dependencies
on go-sqlite3, anything importing pkg/configmap will also need to
enable CGO.
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 24, 2020
@benluddy benluddy requested a review from njhale January 24, 2020 23:41
@benluddy benluddy mentioned this pull request Jan 24, 2020
Closed
@njhale
Copy link
Member

njhale commented Jan 27, 2020

nice!

@benluddy
Copy link
Contributor Author

/retest

1 similar comment
@benluddy
Copy link
Contributor Author

/retest

@benluddy benluddy changed the title Remove dependency on sqlite from pkg/configmap. Bug 1795658: Remove dependency on sqlite from pkg/configmap. Jan 28, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 28, 2020
@openshift-ci-robot
Copy link

@benluddy: This pull request references Bugzilla bug 1795658, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1795658: Remove dependency on sqlite from pkg/configmap.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kevinrizza
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 28, 2020
dinhxuanvu
dinhxuanvu approved these changes Jan 28, 2020
View reviewed changes
Copy link
Member

@dinhxuanvu dinhxuanvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2020
@ecordell
Copy link
Member

/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benluddy, dinhxuanvu, ecordell, kevinrizza

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dinhxuanvu,ecordell]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@benluddy
Copy link
Contributor Author

/retest

2 similar comments
@benluddy
Copy link
Contributor Author

/retest

@benluddy
Copy link
Contributor Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit 56036a9 into operator-framework:master Jan 29, 2020
@openshift-ci-robot
Copy link

@benluddy: All pull requests linked via external trackers have merged. Bugzilla bug 1795658 has been moved to the MODIFIED state.

In response to this:

Bug 1795658: Remove dependency on sqlite from pkg/configmap.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@benluddy benluddy deleted the remove-sqlite-dep-from-configmap branch January 29, 2020 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dinhxuanvu dinhxuanvu dinhxuanvu approved these changes

@ecordell ecordell Awaiting requested review from ecordell

@njhale njhale Awaiting requested review from njhale

Assignees

@ecordell ecordell

@kevinrizza kevinrizza

@dinhxuanvu dinhxuanvu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@benluddy @njhale @openshift-ci-robot @kevinrizza @ecordell @dinhxuanvu @openshift-merge-robot