Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1815957: fix(dns): fix slow dns resolution of localhost for grpc health probe #227

Merged
merged 1 commit into from Mar 30, 2020

Conversation

ecordell
Copy link
Member

Description of the change:
Adds an nsswitch.conf to prefer local files over dns for resolution.

Motivation for the change:
see: golang/go#35305

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2020
@njhale
Copy link
Member

njhale commented Mar 25, 2020

Cool! Here's what I found:

  1. I think we should add the file for all generated Dockerfiles, since we don't know if the given base image contains it.
  2. Looks like image builds are failing on chmod to /dev. I don't think the failure is related to any changes here. Since the blame is months old, my primary suspect is that the base image was swapped out under us in CI again.

@ecordell
Copy link
Member Author

I think we should add the file for all generated Dockerfiles, since we don't know if the given base image contains it.

This is tricky, since the source image can vary on user input and there's no guarantee we'll have echo

@njhale
Copy link
Member

njhale commented Mar 26, 2020

@ecordell, then do you think opm should just attempt to generate the file at runtime?

@ecordell
Copy link
Member Author

ecordell commented Mar 26, 2020

@njhale Updated with your suggestion.

In the downstream image, nsswitch is already populated correctly. I tested with the upstream image as well:

/go # cat /etc/nsswitch.conf
cat: can't open '/etc/nsswitch.conf': No such file or directory
/go # /registry-server &
/go # cat /etc/nsswitch.conf
hosts: files dns/go

@ecordell
Copy link
Member Author

/retest

1 similar comment
@ecordell
Copy link
Member Author

/retest

@exdx
Copy link
Member

exdx commented Mar 30, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 30, 2020
Copy link
Member

@dinhxuanvu dinhxuanvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@awgreene awgreene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awgreene, dinhxuanvu, ecordell, exdx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dinhxuanvu,ecordell]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 1186793 into operator-framework:master Mar 30, 2020
@ecordell ecordell changed the title fix(dns): fix slow dns resolution of localhost for grpc health probe Bug 1815957: fix(dns): fix slow dns resolution of localhost for grpc health probe Apr 12, 2020
@openshift-ci-robot
Copy link

@ecordell: Some pull requests linked via external trackers have merged: . The following pull requests linked via external trackers have not merged:

In response to this:

Bug 1815957: fix(dns): fix slow dns resolution of localhost for grpc health probe

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ecordell
Copy link
Member Author

/cherry-pick release-4.4

@openshift-cherrypick-robot

@ecordell: new pull request created: #269

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants