Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix panic in registry add #248

Merged
merged 2 commits into from Apr 2, 2020
Merged

Fix panic in registry add #248

merged 2 commits into from Apr 2, 2020

Conversation

njhale
Copy link
Member

@njhale njhale commented Apr 2, 2020

Description of the change:

  • Fix panic during registry add
  • Set missing bundle name to prevent registry add from failing

@njhale
fix(populator): put correct argument in decode call
7c2956e 
Fix a panic in the populator code caused by giving the wrong argument to
the decodeFile function. Also, add a better panic message indicating
programming error.
@njhale
fix(populator): set bundle name
73d3eb2 
Add missing name assignment to fix registry add errors.
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 2, 2020
@Bowenislandsong
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 2, 2020
@Bowenislandsong
Copy link
Member

/hold
for @awgreene review

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 2, 2020
awgreene
awgreene approved these changes Apr 2, 2020
View reviewed changes
Copy link
Member

@awgreene awgreene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@awgreene
Copy link
Member

awgreene commented Apr 2, 2020

/unhold

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 2, 2020
djzager
djzager approved these changes Apr 2, 2020
View reviewed changes
Copy link
Contributor

@djzager djzager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix.

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awgreene, djzager, njhale

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 1a514b0 into operator-framework:master Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djzager djzager djzager approved these changes

@awgreene awgreene awgreene approved these changes

@dinhxuanvu dinhxuanvu Awaiting requested review from dinhxuanvu

Assignees

@awgreene awgreene

@Bowenislandsong Bowenislandsong

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@njhale @Bowenislandsong @awgreene @openshift-ci-robot @djzager @openshift-merge-robot