feat: generate a bundle with configmap and secret objects #256
Conversation
There was a problem hiding this comment.
Spoke to Dan and did some testing, it seems like the registry insert doesn't gate on arbitrary yaml files.
We should potentially do a followup -- it could be the case that arbitrary yaml files are inserted here if you don't use opm to build your bundle. Should we gate when inserting into the registry? Right now as long as it's valid yaml or json we don't care.
/approve
openshift-ci-robot
added
the
approved
...ate/valid_bundle_additional_objects/manifests/etcdrestores.etcd.database.coreos.com.crd.yaml
Outdated
Show resolved
Hide resolved
exdx
force-pushed
the
feat/add-bundle-objects
branch
from
1171e39
to
8af4f19
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ecordell, exdx, kevinrizza The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Description of the change:
Adds support for users putting configmap and secret objects inside their bundle. Part of the work to increase the flexibility of OLM for users. OLM knows how to install secrets from an install plan currently, but support for configmaps will be added as well.
Currently no validation for these new objects is done (outside of them being valid kube objects) but they are whitelisted and will be installed when OLM installs the bundle.
Motivation for the change:
Reviewer Checklist
/docs