Add dependencies validation to opm #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
approved
dinhxuanvu
changed the title
openshift-ci-robot
added
the
do-not-merge/work-in-progress
dinhxuanvu
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
@ecordell Ready for final review |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dinhxuanvu, ecordell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
benluddy
reviewed
Apr 17, 2020
dinhxuanvu
force-pushed
the
opm-dep
branch
2 times, most recently
from
ad8b395
to
efbfd24
Compare
Signed-off-by: Vu Dinh <vdinh@redhat.com>
Signed-off-by: Vu Dinh <vdinh@redhat.com>
Signed-off-by: Vu Dinh <vdinh@redhat.com>
Signed-off-by: Vu Dinh <vdinh@redhat.com>
benluddy
reviewed
Apr 20, 2020
Signed-off-by: Vu Dinh <vdinh@redhat.com>
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Add dependencies.yaml validation to opm
Signed-off-by: Vu Dinh vdinh@redhat.com
Motivation for the change:
Add dependencies validation checks to bundle library in registry
Reviewer Checklist
/docs