Use auth from opsrc #28
Conversation
|
Put this wip pr up for now to review, still need to merge the auth pr on operator-marketplace and then update vendored dependencies. |
| return options, err | ||
| } | ||
|
|
||
| options.AuthToken = string(secret.Data["token"]) |
There was a problem hiding this comment.
I thought we needed to base64 decode it.
There was a problem hiding this comment.
@tkashem Nope, the api just obfuscates it as base64, but when pulling from the client directly it is returned as a string.
pkg/appregistry/appregistry.go
Outdated
| @@ -100,3 +107,23 @@ func NewClient(kubeconfig string, logger *logrus.Entry) (clientset marketplace.I | |||
| clientset, err = marketplace.NewForConfig(config) | |||
| return | |||
| } | |||
|
|
|||
| func NewSecretClient(kubeconfig string, logger *logrus.Entry) (clientset *kubernetes.Clientset, err error) { | |||
There was a problem hiding this comment.
nit: maybe kubeclient is a more appropriate name?
There was a problem hiding this comment.
Sure, updated in latest commit. I also updated the field name in the downloader to match
kevinrizza
force-pushed
the
auth-in-appregistry
branch
from
588d4df
to
516ef1a
Compare
openshift-ci-robot
added
the
size/L
|
/lgtm |
openshift-ci-robot
added
lgtm
|
/lgtm |
-Query opsrc for secret name -Update downloader to get auth token secret -Use auth token in apprclient request header -Update vendored marketplace version
kevinrizza
force-pushed
the
auth-in-appregistry
branch
from
b195849
to
7a4b0a3
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kevinrizza, njhale, tkashem The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/test e2e-aws |
-Query opsrc for secret name
-Update downloader to get auth token secret
-Use auth token in apprclient request header