Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1826766: fix(types): Fix GetDependencies func that returns duplicate items #289

Merged
merged 1 commit into from Apr 28, 2020
Merged

Bug 1826766: fix(types): Fix GetDependencies func that returns duplicate items #289

merged 1 commit into from Apr 28, 2020

Conversation

dinhxuanvu
Copy link
Member

The iterator loop reuses item pointer which leads to duplicate of the
same dependencies while other dependencies are missing out.

Signed-off-by: Vu Dinh vdinh@redhat.com

Description of the change:

Motivation for the change:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 20, 2020
@dinhxuanvu dinhxuanvu changed the title fix(types): Fix GetDependencies func that returns duplicate items Bug 1826766: fix(types): Fix GetDependencies func that returns duplicate items Apr 22, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/unspecified bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Apr 22, 2020
@openshift-ci-robot
Copy link

@dinhxuanvu: This pull request references Bugzilla bug 1826766, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1826766: fix(types): Fix GetDependencies func that returns duplicate items

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ecordell
ecordell reviewed Apr 27, 2020
View reviewed changes
pkg/registry/types.go Outdated Show resolved Hide resolved
@dinhxuanvu
fix(types): Fix GetDependencies func that returns duplicate items
cfb8d0f 
The iterator loop reuses item pointer which leads to duplicate of the
same dependencies while other dependencies are missing out.

Signed-off-by: Vu Dinh <vdinh@redhat.com>
@ecordell
Copy link
Member

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dinhxuanvu, ecordell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dinhxuanvu,ecordell]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dinhxuanvu
Copy link
Member Author

/bugzilla refresh

@openshift-ci-robot
Copy link

@dinhxuanvu: This pull request references Bugzilla bug 1826766, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. label Apr 27, 2020
@kevinrizza
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 27, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit bf0c8f1 into operator-framework:master Apr 28, 2020
@openshift-ci-robot
Copy link

@dinhxuanvu: All pull requests linked via external trackers have merged: operator-framework/operator-registry#289. Bugzilla bug 1826766 has been moved to the MODIFIED state.

In response to this:

Bug 1826766: fix(types): Fix GetDependencies func that returns duplicate items

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecordell ecordell ecordell left review comments

@kevinrizza kevinrizza Awaiting requested review from kevinrizza

@njhale njhale Awaiting requested review from njhale

@benluddy benluddy Awaiting requested review from benluddy

Assignees

@kevinrizza kevinrizza

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@dinhxuanvu @openshift-ci-robot @ecordell @kevinrizza @openshift-bot @openshift-merge-robot