Bug 1820438: Slim down upstream builder #298
Conversation
With the static build fix for index images committed (operator-framework#173), we introduced a side effect of index images including all the build layers included in the build image. That bloated the index images using the default from image by over 1gb in size. To resolve this, this commit introduces two changes. First, it adds a multistage build to the upstream builder to just copy the output of the build into a scratch image rather than include all the layers from the base alpine image. Second, it adds a new opm dockerfile with the same format except that only the binaries needed to host index images are included. After this commit is merged, a release should be cut and the dockerfile generator needs to be updated to point to a new opm builder as the default from index
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kevinrizza The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
approved
|
@kevinrizza: This pull request references Bugzilla bug 1820438, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@kevinrizza: This pull request references Bugzilla bug 1820438, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
@kevinrizza: All pull requests linked via external trackers have merged: operator-framework/operator-registry#298. Bugzilla bug 1820438 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
With the static build fix for index images committed (#173),
we introduced a side effect of index images including all the
build layers included in the build image. That bloated the index images
using the default from image by over 1gb in size.
To resolve this, this commit introduces two changes. First, it adds a
multistage build to the upstream builder to just copy the output of the
build into a scratch image rather than include all the layers from the
base alpine image. Second, it adds a new opm dockerfile with the same
format except that only the binaries needed to host index images are
included.
After this commit is merged, a release should be cut and the dockerfile
generator needs to be updated to point to a new opm builder as the
default from index
Partially resolves #218, though a followup is needed.