Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1827906: (fix) Use opm builder image for opm indexes #299

Merged
merged 1 commit into from Apr 25, 2020
Merged

Bug 1827906: (fix) Use opm builder image for opm indexes #299

merged 1 commit into from Apr 25, 2020

Conversation

kevinrizza
Copy link
Member

Revert the upstream-builder changes since they break compatibility with
a number of workflows. Instead, just point the dockerfile generator to
new opm-builder image for upstream.

Additionally, update existing docs and dockerfile examples to point to
/bin instead of /build/bin for registry examples

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2020
anik120
anik120 approved these changes Apr 24, 2020
View reviewed changes
Copy link
Contributor

@anik120 anik120 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit, otherwise /lgtm

upstream-builder.Dockerfile Outdated
cp /build/bin/initializer /bin/initializer && \
cp /build/bin/appregistry-server /bin/appregistry-server && \
cp /build/bin/configmap-server /bin/configmap-server && \
cp /build/bin/registry-server /bin/registry-server
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit: EOL

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed. thanks!

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anik120, kevinrizza

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kevinrizza
(fix) Use opm builder image for opm indexes
c7e15c3 
Revert the upstream-builder changes since they break compatibility with
a number of workflows. Instead, just point the dockerfile generator to
new opm-builder image for upstream.

Additionally, update existing docs and dockerfile examples to point to
/bin instead of /build/bin for registry examples
@ecordell
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2020
@ecordell ecordell changed the title (fix) Use opm builder image for opm indexes Bug 1827906: (fix) Use opm builder image for opm indexes Apr 25, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. label Apr 25, 2020
@openshift-ci-robot
Copy link

@kevinrizza: This pull request references Bugzilla bug 1827906, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1827906: (fix) Use opm builder image for opm indexes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Apr 25, 2020
@openshift-merge-robot openshift-merge-robot merged commit 2191b65 into operator-framework:master Apr 25, 2020
@openshift-ci-robot
Copy link

@kevinrizza: All pull requests linked via external trackers have merged: operator-framework/operator-registry#299. Bugzilla bug 1827906 has been moved to the MODIFIED state.

In response to this:

Bug 1827906: (fix) Use opm builder image for opm indexes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anik120 anik120 anik120 approved these changes

@dinhxuanvu dinhxuanvu Awaiting requested review from dinhxuanvu

@gallettilance gallettilance Awaiting requested review from gallettilance

Assignees

@ecordell ecordell

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kevinrizza @openshift-ci-robot @ecordell @anik120 @openshift-merge-robot