Bug 1840370: Configure "podman build" to produce images with Docker manifests. #337
Conversation
|
/test unit |
benluddy
force-pushed
the
podman-index-docker-format
branch
from
5eb38ea
to
9338ad9
Compare
|
/test e2e-aws |
benluddy
changed the title
openshift-ci-robot
added
the
bugzilla/severity-low
|
@benluddy: This pull request references Bugzilla bug 1840370, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
| func (p *PodmanCommandFactory) BuildCommand(o BuildOptions) (*exec.Cmd, error) { | ||
| args := []string{"build"} | ||
|
|
||
| if o.format != "" { |
There was a problem hiding this comment.
Dumb thought: do we ever want to consider just passing arbitrary command arguments here rather than being explicit with flags? It might make for a simpler cli experience. Especially if we make the default for build fully daemonless
The counter is that we're on the hook for making all of these arbitrary flags work? 🤷
There was a problem hiding this comment.
I think you could make a good argument for that, but I lean towards letting users directly invoke podman/whatever if they are in a circumstance that calls for it.
Podman's default is to produce OCI manifests and metadata, while Docker (unsurprisingly) produces the Docker filetypes. This can lead to behavior differences down the line, especially once container registries are added to the mix.
benluddy
force-pushed
the
podman-index-docker-format
branch
from
9338ad9
to
a9d758c
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benluddy, kevinrizza The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@benluddy: All pull requests linked via external trackers have merged: operator-framework/operator-registry#337. Bugzilla bug 1840370 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Podman's default is to produce OCI manifests and metadata, while
Docker (unsurprisingly) produces the Docker filetypes. This can lead
to behavior differences down the line, especially once container
registries are added to the mix.