Bug 1835884: opm bundle extract shouldn't validate annotations #338
Conversation
Currently, the configmap writer attempts to validate the annotations associated with the bundle. In reality, most of these annotations are currently unused by the time the bundle is being unpacked and applied to the cluster. There was an issue where default channel was no longer required, but it was still validated by extract because it has a separate validation function. These annotations should be validated when building and adding to the registry (as it exists now). This commit removes annotation validation from the configmap writer in opm alpha bundle extract
openshift-ci-robot
added
bugzilla/severity-unspecified
|
@kevinrizza: This pull request references Bugzilla bug 1834884, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kevinrizza The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
kevinrizza
changed the title
openshift-ci-robot
added
bugzilla/severity-urgent
|
@kevinrizza: This pull request references Bugzilla bug 1835884, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
removed
the
bugzilla/invalid-bug
|
/bugzilla refresh |
|
@kevinrizza: This pull request references Bugzilla bug 1835884, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
openshift-ci-robot
added
the
do-not-merge/hold
|
/lgtm |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
| source: "testdata/bundle-with-no-default-channel.yaml", | ||
| assertFunc: func(t *testing.T, bundleGot *api.Bundle) { | ||
| csvGot := bundleGot.GetCsvJson() | ||
| assert.NotNil(t, csvGot) |
There was a problem hiding this comment.
Nit: Pointless assertion, csvGot is a string. Actually, two tests above this one asserts nothing but this.
|
/test e2e-aws |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@kevinrizza: All pull requests linked via external trackers have merged: operator-framework/operator-registry#338. Bugzilla bug 1835884 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Currently, the configmap writer attempts to validate the annotations
associated with the bundle. In reality, most of these annotations are
currently unused by the time the bundle is being unpacked and applied
to the cluster. There was an issue where default channel was no longer
required, but it was still validated by extract because it has a
separate validation function.
These annotations should be validated when building and
adding to the registry (as it exists now). This pr removes
annotation validation from the configmap writer in opm alpha bundle
extract.