Separate build/pull tool for index rm #374
Conversation
Like the index add command, index rm can separate the tool/lib that pulls and unpacks index images from the tool that builds them. This commit introduces that separation to index rm, defaulting pull tool to none(using internal containerd libs for pulling) from the build tool that defaults to podman.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kevinrizza The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| if containerTool == "none" { |
There was a problem hiding this comment.
I know we have a lot of conversations around non-tool. I couldn't keep track of what's going on there, Is there any reason we are removing the check here? Thanks.
otherwise lgtm
There was a problem hiding this comment.
The concept of that check was just moved into the existing private method getContainerTools(), which I'm reusing the logic for:
https://github.com/operator-framework/operator-registry/blob/master/cmd/opm/index/add.go#L162
There was a problem hiding this comment.
ahh, nice. Thanks
/lgtm
/hold
waiting for a second review
openshift-ci-robot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/retest |
|
/test e2e-aws |
|
/retest |
|
/override ci/prow/e2e-aws Overriding because the test is flaking and this is critical fix for production. The Travis test passed is in verifying this change |
|
@shawn-hurley: Overrode contexts on behalf of shawn-hurley: ci/prow/e2e-aws In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/override ci/prow/e2e-aws |
|
@shawn-hurley: Overrode contexts on behalf of shawn-hurley: ci/prow/e2e-aws In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Like the index add command, index rm can separate the tool/lib that
pulls and unpacks index images from the tool that builds them. This
commit introduces that separation to index rm, defaulting pull tool to
none(using internal containerd libs for pulling) from the build tool
that defaults to podman.