Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add USER for non-root image usage #425

Merged
merged 1 commit into from Oct 6, 2020
Merged

Add USER for non-root image usage #425

merged 1 commit into from Oct 6, 2020

Conversation

kramvan1
Copy link
Contributor

Fixes #424

Description of the change:

run the configmap operator registry image with non-root user account

Motivation for the change:

Using root is a potential security violation

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage N/A
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs N/A
  • Commit messages sensible and descriptive

@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 21, 2020
@openshift-ci-robot
Copy link

Hi @kramvan1. Thanks for your PR.

I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kramvan1
Copy link
Contributor Author

/assign @dinhxuanvu

@kramvan1
Copy link
Contributor Author

@njhale @dinhxuanvu Thoughts on this, fairly straight forward change here.

@dinhxuanvu
Copy link
Member

/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 24, 2020
@kramvan1
Copy link
Contributor Author

/retest

@kramvan1
Copy link
Contributor Author

@dinhxuanvu Does that tide test ever come back?

@dinhxuanvu
Copy link
Member

@kramvan1 The tide is pending because it requires a lgtm and approve. Plus, because we are still in feature freeze state, every PR requires a BZ in order to be merged.

@kramvan1
Copy link
Contributor Author

@dinhxuanvu Thx for the updates. How to know feature freeze schedule?

@ecordell
Copy link
Member

ecordell commented Sep 8, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 8, 2020
@njhale
Copy link
Member

njhale commented Sep 17, 2020 •
edited

@kramvan1 sorry for the delayed response here. Master opens on Oct. 2nd.

We're currently working to decouple operator-framework repositories from some platform build infrastructure, which will let us merge code independently, but I don't want to claim this will happen before Oct. 2nd.

@njhale
Copy link
Member

njhale commented Sep 17, 2020

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kramvan1, njhale

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 17, 2020
@kramvan1
Copy link
Contributor Author

@njhale Thx for the update.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@kramvan1
Copy link
Contributor Author

kramvan1 commented Oct 5, 2020

/retest

1 similar comment
@kramvan1
Copy link
Contributor Author

kramvan1 commented Oct 5, 2020

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 3cce6e7 into operator-framework:master Oct 6, 2020
@benluddy benluddy mentioned this pull request Oct 12, 2020
Closed
@pamelachristie pamelachristie mentioned this pull request Jan 20, 2021
Open
@pamelachristie pamelachristie mentioned this pull request Mar 1, 2021
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dinhxuanvu dinhxuanvu Awaiting requested review from dinhxuanvu

@njhale njhale Awaiting requested review from njhale

Assignees

@ecordell ecordell

@dinhxuanvu dinhxuanvu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

configmap-operator-registry image as running as root, security violation
7 participants
@kramvan1 @openshift-ci-robot @dinhxuanvu @ecordell @njhale @openshift-bot @openshift-merge-robot