Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1881527: fix(opm): properly deprecate export flag '-o' #485

Merged
merged 1 commit into from Oct 22, 2020

Conversation

njhale
Copy link
Member

@njhale njhale commented Oct 20, 2020

Add a hidden alias for the -p flag of opm index export. This properly
deprecates the -o shorthand, making the cli backwards compatible for
clients that haven't switched over to -p.

Note: there's not really a good native option for deprecating flag shorthands without defining a new flag, thus the given implementation.

Add a hidden alias for the `-p` flag of opm index export. This properly
deprecates the `-o` shorthand, making the cli backwards compatible for
clients that haven't switched over to `-p`.
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 20, 2020
@njhale njhale changed the title fix(opm): properly deprecate export flag '-o' Bug 1881527: fix(opm): properly deprecate export flag '-o' Oct 20, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Oct 20, 2020
@openshift-ci-robot
Copy link

@njhale: This pull request references Bugzilla bug 1881527, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1881527: fix(opm): properly deprecate export flag '-o'

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Oct 20, 2020
@kevinrizza
Copy link
Member

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kevinrizza, njhale

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@njhale
Copy link
Member Author

njhale commented Oct 20, 2020

/test unit

@ecordell
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 22, 2020
@benluddy
Copy link
Contributor

/test unit

#482

@openshift-merge-robot openshift-merge-robot merged commit 3cafc8d into operator-framework:master Oct 22, 2020
@openshift-ci-robot
Copy link

@njhale: All pull requests linked via external trackers have merged:

Bugzilla bug 1881527 has been moved to the MODIFIED state.

In response to this:

Bug 1881527: fix(opm): properly deprecate export flag '-o'

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants