Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copy .git directory for build tag info #509

Conversation

ankitathomas
Copy link
Contributor

Copy .git directory to intermediary build container to provide make with the tag and sha for an opm build.

Closes #507

@benluddy
Copy link
Contributor

benluddy commented Nov 4, 2020

Is there any reason not to copy the entire build context into the builder stage rather than enumerating files/directories like this?

@ankitathomas
Copy link
Contributor Author

Is there any reason not to copy the entire build context into the builder stage rather than enumerating files/directories like this?

If the build context is clean, then we could just copy the entire build context.

@codecov
Copy link

codecov bot commented Nov 11, 2020

Codecov Report

Merging #509 (0ca071f) into master (bfe56a7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #509   +/-   ##
=======================================
  Coverage   48.73%   48.73%           
=======================================
  Files          90       90           
  Lines        6103     6103           
=======================================
  Hits         2974     2974           
  Misses       2469     2469           
  Partials      660      660           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfe56a7...066dfe2. Read the comment docs.

@ankitathomas
Copy link
Contributor Author

/retest

1 similar comment
@ankitathomas
Copy link
Contributor Author

/retest

Copy link
Member

@njhale njhale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2020
Copy link
Member

@dinhxuanvu dinhxuanvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Dockerfile Show resolved Hide resolved
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ankitathomas, dinhxuanvu, njhale

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@benluddy
Copy link
Contributor

/retest

1 similar comment
@benluddy
Copy link
Contributor

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit fded0bf into operator-framework:master Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upstream-opm-builder image does not populate the version in opm.
7 participants