New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
copy .git directory for build tag info #509
copy .git directory for build tag info #509
Conversation
Is there any reason not to copy the entire build context into the builder stage rather than enumerating files/directories like this? |
If the build context is clean, then we could just copy the entire build context. |
1aadeef
to
066dfe2
Compare
Codecov Report
@@ Coverage Diff @@
## master #509 +/- ##
=======================================
Coverage 48.73% 48.73%
=======================================
Files 90 90
Lines 6103 6103
=======================================
Hits 2974 2974
Misses 2469 2469
Partials 660 660 Continue to review full report at Codecov.
|
/retest |
1 similar comment
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ankitathomas, dinhxuanvu, njhale The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest |
1 similar comment
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
Copy .git directory to intermediary build container to provide make with the tag and sha for an opm build.
Closes #507