Bug 1889865: Avoid duplicate registry binaries across downstream image layers. #535
Conversation
The registry binaries are copied from the build stage to an intermediate directory because the downstream image builder overwrites the destination directory when the source is a glob pattern. The existing COPY and RUN (mv) commands both add a layer to the image, so a copy of each binary lives in each layer. To avoid this, symlinks are created from /bin to the intermediate directory instead of moving the binaries from the intermediate directory to /bin.
|
@benluddy: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benluddy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
benluddy
changed the title
openshift-ci-robot
added
the
bugzilla/severity-medium
|
@benluddy: This pull request references Bugzilla bug 1889865, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
/lgtm |
jwforres
added
the
cherry-pick-approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@benluddy: All pull requests linked via external trackers have merged: Bugzilla bug 1889865 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The registry binaries are copied from the build stage to an
intermediate directory because the downstream image builder overwrites
the destination directory when the source is a glob pattern. The
existing COPY and RUN (mv) commands both add a layer to the image, so
a copy of each binary lives in each layer.
To avoid this, symlinks are created from /bin to the intermediate
directory instead of moving the binaries from the intermediate
directory to /bin.