Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move upstream tests from travisCI #536

Merged
merged 1 commit into from Dec 11, 2020

Conversation

exdx
Copy link
Member

@exdx exdx commented Dec 9, 2020

Description of the change:
Move upstream tests to Github Actions and remove TravisCI configuration entirely.

Upstream actions were added as well as an update to the release docs. The existing release CI was not changed but the unit job was consolidated as part of the upstream tests. The only functional change was codecov reported errors did not result in a CI failure.

Prerequisite for getting the opm e2e tests to run as expected again

Motivation for the change:
Travis changed their policy around supporting open source repositories

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

@exdx exdx changed the title feat: move upstream tests from travisCI chore: move upstream tests from travisCI Dec 9, 2020
@codecov
Copy link

codecov bot commented Dec 9, 2020

Codecov Report

Merging #536 (d82884e) into master (2e9bb75) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #536   +/-   ##
=======================================
  Coverage   49.45%   49.45%           
=======================================
  Files          90       90           
  Lines        6317     6317           
=======================================
  Hits         3124     3124           
  Misses       2497     2497           
  Partials      696      696           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e9bb75...d82884e. Read the comment docs.

@exdx exdx force-pushed the feat/github-actions branch 4 times, most recently from 33d61a0 to c5ea4ec Compare December 9, 2020 20:43
@exdx exdx closed this Dec 9, 2020
@exdx exdx reopened this Dec 9, 2020
@exdx exdx force-pushed the feat/github-actions branch 9 times, most recently from c21ba81 to aa003b9 Compare December 10, 2020 21:30
@exdx
Copy link
Member Author

exdx commented Dec 10, 2020

The upstream e2e tests now match the e2e results locally - all but one test is skipped and the remaining test fails. This will be addressed in follow-up PRs but I believe this PR fulfills its original goal of moving upstream CI to Github Actions

@exdx
Copy link
Member Author

exdx commented Dec 10, 2020

/bugzilla override

Copy link
Contributor

@ankitathomas ankitathomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

.github/workflows/upstreams-tests.yml Outdated Show resolved Hide resolved
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 11, 2020
@exdx
Copy link
Member Author

exdx commented Dec 11, 2020

/test e2e-aws

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 11, 2020
@benluddy
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ankitathomas, benluddy, exdx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 11, 2020
@hasbro17
Copy link

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 11, 2020
@exdx
Copy link
Member Author

exdx commented Dec 11, 2020

This PR will be merged manually since there is no accompanying BZ and it only introduces net-new CI. The e2e CI has now been moved to GitHub Actions as intended -- the fact that kind CI is red is intentional and does not block any registry PRs (these Actions are not required for prow to merge). The failing CI should bring attention to the fact that the registry e2e tests are not working as intended, 10/11 tests are being skipped as they were on TravisCI.

Subsequent work will be done to address the skipped e2e tests and the issue that causes the Launch bundle test to fail on kind -- since this test builds images on the host and then uses them within the kind cluster there is no way to share these images without an overhaul of the test.

@exdx
Copy link
Member Author

exdx commented Dec 11, 2020

/override ci/prow/e2e-aws

@openshift-ci-robot
Copy link

@exdx: Overrode contexts on behalf of exdx: ci/prow/e2e-aws

In response to this:

/override ci/prow/e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@exdx exdx merged commit b59ef52 into operator-framework:master Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants