Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating operator-registry builder & base images to be consistent with ART #584

Merged
merged 1 commit into from Mar 2, 2021
Merged

Updating operator-registry builder & base images to be consistent with ART #584

merged 1 commit into from Mar 2, 2021

Conversation

openshift-bot
Copy link
Contributor

@openshift-bot openshift-bot commented Feb 18, 2021 •
edited

Updating operator-registry builder & base images to be consistent with ART
Reconciling with https://github.com/openshift/ocp-build-data/tree/99d610a8a3a83f68f04d5440e529c2b16776fa67/images/operator-registry.yml

If you have any questions about this pull request, please reach out to @art-team in the #aos-art coreos slack channel.

@openshift-ci-robot
Copy link

@openshift-bot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Updating operator-registry builder & base images to be consistent with ART

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

Hi @openshift-bot. Thanks for your PR.

I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 18, 2021
@codecov
Copy link

codecov bot commented Feb 18, 2021 •
edited

Codecov Report

Merging #584 (ffb7bd1) into release-4.7 (8e6c13f) will increase coverage by 0.03%.
The diff coverage is 44.18%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-4.7     #584      +/-   ##
===============================================
+ Coverage        49.45%   49.49%   +0.03%     
===============================================
  Files               90       91       +1     
  Lines             6317     6302      -15     
===============================================
- Hits              3124     3119       -5     
+ Misses            2497     2492       -5     
+ Partials           696      691       -5
Impacted Files Coverage Δ
pkg/appregistry/dbloader.go 0.00% <0.00%> (ø)
pkg/lib/indexer/indexer.go 6.93% <0.00%> (ø)
pkg/sqlite/query.go 67.08% <0.00%> (ø)
pkg/sqlite/remove.go 0.00% <ø> (ø)
pkg/sqlite/stranded.go 0.00% <0.00%> (ø)
pkg/sqlite/load.go 41.67% <46.87%> (-0.12%) ⬇️
pkg/sqlite/db.go 50.00% <50.00%> (ø)
pkg/appregistry/builder.go 31.73% <100.00%> (ø)
pkg/mirror/mirror.go 34.14% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e6c13f...a6cdcdf. Read the comment docs.

@dinhxuanvu
Copy link
Member

/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 18, 2021
@openshift-ci-robot
Copy link

@openshift-bot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Updating operator-registry builder & base images to be consistent with ART

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci-robot
Copy link

@openshift-bot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Updating operator-registry builder & base images to be consistent with ART

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@timflannagan
Copy link
Contributor

/retest

@openshift-ci-robot
Copy link

@openshift-bot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Updating operator-registry builder & base images to be consistent with ART

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci-robot
Copy link

@openshift-bot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Updating operator-registry builder & base images to be consistent with ART

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@timflannagan
Copy link
Contributor

/test all

1 similar comment
@timflannagan
Copy link
Contributor

/test all

@timflannagan
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 1, 2021
@timflannagan
Copy link
Contributor

Manually adding the bugzilla/valid-bug and cherry-pick-approved labels as this is a no-op for downstream builds and affects nothing user-facing.

@timflannagan timflannagan added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Mar 1, 2021
@timflannagan
Copy link
Contributor

I'll let someone else tag this with approval permissions.

dinhxuanvu
dinhxuanvu approved these changes Mar 1, 2021
View reviewed changes
Copy link
Member

@dinhxuanvu dinhxuanvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dinhxuanvu, openshift-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 1, 2021
@timflannagan timflannagan added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 1, 2021
@openshift-bot
Copy link
Contributor Author

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor Author

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor Author

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit be599a2 into operator-framework:release-4.7 Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dinhxuanvu dinhxuanvu dinhxuanvu approved these changes

@exdx exdx Awaiting requested review from exdx

@hasbro17 hasbro17 Awaiting requested review from hasbro17

Assignees

@dinhxuanvu dinhxuanvu

@timflannagan timflannagan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@openshift-bot @openshift-ci-robot @dinhxuanvu @timflannagan @openshift-merge-robot