Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove appregistry-related tooling #608

Merged
merged 1 commit into from Apr 1, 2021

Conversation

ecordell
Copy link
Member

@ecordell ecordell commented Mar 25, 2021

Description of the change:
Removes appregistry-server and related code

Motivation for the change:
Appregistry-server was only for openshift support, and hasn't been supported in openshift since 4.5 (deprecated in 4.4).

If there are any straggling appregistry-server users, the existing published binaries should continue to work as long as appregistry is available (the protocol itself is EOLing soon), and should the need arise the appregistry-server can be maintained on existing release branches.

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ecordell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2021
appregistry catalogs have not been supported for some time

Signed-off-by: Evan <cordell.evan@gmail.com>
@codecov
Copy link

codecov bot commented Mar 25, 2021

Codecov Report

Merging #608 (5ebd6d1) into master (4b5d403) will increase coverage by 1.78%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #608      +/-   ##
==========================================
+ Coverage   48.80%   50.59%   +1.78%     
==========================================
  Files          90       68      -22     
  Lines        6276     5483     -793     
==========================================
- Hits         3063     2774     -289     
+ Misses       2528     2097     -431     
+ Partials      685      612      -73     
Impacted Files Coverage Δ
pkg/mirror/options.go 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b5d403...5ebd6d1. Read the comment docs.

@joelanford
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 1, 2021
@openshift-merge-robot openshift-merge-robot merged commit 88eda1a into operator-framework:master Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants