Bug 1783030: Detect replacement cycles while adding package channels

[tmckayus]

If a cycle is created via "replaces" attributes in CSVs, the appregistry-server will infinite loop in the sqlite loader and never serve. This is a simple fix to detect the cycle and fail.

[openshift-ci-robot]

Hi @tmckayus. Thanks for your PR.

I'm waiting for a operator-framework or openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tmckayus]

I ran into this accidentally while editing CSVs :) On a local OCP instance running in a VM, this actually caused qemu to suck up near 100% CPU. This change, in a pod, should cause the pod to fail and enter a crash backoff loop with a log message which should be more clear to a user if they happen to do what I did.

It might be nice to detect this in bundle validation in operator-courier as well.

[tmckayus]

fix for #64

[njhale]

/ok-to-test

Sorry for the delay. Just one small thing and then I think it's good:

[tmckayus]

/test unit

[tmckayus]

rebased on master

[jwforres]

@njhale is this good to merge now?

[njhale]

@jwforres will review today. Currently, we also need to associate a BZ for this to merge, so I'll take care of that today as well.

[openshift-ci-robot]

@tmckayus: This pull request references Bugzilla bug 1783030, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1783030: Detect replacement cycles while adding package channels

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[njhale]

/test unit

[tmckayus]

Thanks for the BZ @njhale . TIL :)

@jwforres will review today. Currently, we also need to associate a BZ for this to merge, so I'll take care of that today as well.

[ecordell]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ecordell, njhale, tmckayus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ecordell,njhale]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tmckayus]

@ecordell @njhale I'm not familiar enough with the CI to know if the failing test is the fault of this PR, or a larger issue. Any insight? Perhaps a rebase maybe?

[njhale]

/retest

[njhale]

Any insight? Perhaps a rebase maybe?
Prow merges master onto the branch before testing. Since it seems there were no conflicts there, I don't think rebasing will help in this case. I retested and everything seemed to work.

After this merges I will manually check master, but I'm fairly certain that this patch doesn't cause any flakes on its own.

[ecordell]

/retest

we're just hitting issues with test infra, doesn't look related to the project itself.

[openshift-ci-robot]

@tmckayus: All pull requests linked via external trackers have merged. Bugzilla bug 1783030 has been moved to the MODIFIED state.

In response to this:

Bug 1783030: Detect replacement cycles while adding package channels

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[njhale]

/cherry-pick release-4.3

[openshift-cherrypick-robot]

@njhale: new pull request created: #345

In response to this:

/cherry-pick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.