Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test for bundlepaths before deprecate #644

Merged
merged 2 commits into from May 6, 2021
Merged

Test for bundlepaths before deprecate #644

merged 2 commits into from May 6, 2021

Conversation

ankitathomas
Copy link
Contributor

Allow deprecatetruncate to handle multiple bundles on the same upgrade chain. Only the most latest bundle in the chain will be marked as deprecated, the remaining will be truncated with the rest of the upgrade chain older than the deprecated bundle.

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ankitathomas
To complete the pull request process, please assign ecordell after the PR has been reviewed.
You can assign the PR to them by writing /assign @ecordell in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ankitathomas ankitathomas requested review from gallettilance and anik120 and removed request for jmrodri April 22, 2021 16:52
@ankitathomas ankitathomas force-pushed the deprecate-fix branch 2 times, most recently from e67a60b to 6ff9a97 Compare April 22, 2021 16:55
@codecov
Copy link

codecov bot commented Apr 22, 2021 •
edited

Codecov Report

Merging #644 (5320089) into master (cbcacd3) will increase coverage by 1.28%.
The diff coverage is 66.66%.

❗ Current head 5320089 differs from pull request most recent head 05d78f0. Consider uploading reports for the commit 05d78f0 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #644      +/-   ##
==========================================
+ Coverage   48.40%   49.68%   +1.28%     
==========================================
  Files          87       87              
  Lines        7599     7624      +25     
==========================================
+ Hits         3678     3788     +110     
+ Misses       3195     3062     -133     
- Partials      726      774      +48
Impacted Files Coverage Δ
pkg/registry/empty.go 0.00% <0.00%> (ø)
pkg/sqlite/load.go 40.52% <0.00%> (+7.19%) ⬆️
pkg/sqlite/query.go 68.18% <69.23%> (+0.01%) ⬆️
pkg/sqlite/deprecate.go 72.72% <75.00%> (+72.72%) ⬆️
pkg/sqlite/loadprocs.go 33.33% <0.00%> (+33.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83884aa...05d78f0. Read the comment docs.

@ankitathomas ankitathomas changed the title [Bug 195053] test for bundlepaths before deprecate Test for bundlepaths before deprecate Apr 26, 2021
@ankitathomas
Copy link
Contributor Author

/retest

@hasbro17
Copy link

SGTM overall.

@ankitathomas ankitathomas force-pushed the deprecate-fix branch 2 times, most recently from 9827889 to 2b5c168 Compare April 30, 2021 19:25
@ankitathomas
check presence of all bundles before deprecate
7b2faba 
Signed-off-by: Ankita Thomas <ankithom@redhat.com>
hasbro17
hasbro17 reviewed Apr 30, 2021
View reviewed changes
Copy link

@hasbro17 hasbro17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 30, 2021
@timflannagan
Copy link
Contributor

/skip

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label May 3, 2021
@ankitathomas
revert api signatures
05d78f0 
Signed-off-by: Ankita Thomas <ankithom@redhat.com>
@timflannagan
Copy link
Contributor

/rerun-all

@timflannagan
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 3, 2021
@ankitathomas ankitathomas merged commit af1039f into operator-framework:master May 6, 2021
@ankitathomas ankitathomas mentioned this pull request May 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasbro17 hasbro17 hasbro17 left review comments

@dinhxuanvu dinhxuanvu Awaiting requested review from dinhxuanvu

@gallettilance gallettilance Awaiting requested review from gallettilance

@anik120 anik120 Awaiting requested review from anik120

@timflannagan timflannagan Awaiting requested review from timflannagan

Assignees

@hasbro17 hasbro17

@timflannagan timflannagan

Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ankitathomas @openshift-ci-robot @hasbro17 @timflannagan