Improve load func error handling to expose more information #647
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dinhxuanvu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Codecov Report
@@ Coverage Diff @@
## master #647 +/- ##
==========================================
- Coverage 48.44% 48.40% -0.04%
==========================================
Files 87 87
Lines 7592 7598 +6
==========================================
Hits 3678 3678
- Misses 3188 3194 +6
Partials 726 726
Continue to review full report at Codecov.
|
|
This looks reasonable to me besides the error capitalization issue I linked to and the codecov lines outlined by the bot that don't have any coverage. |
Many of sqlite query returns errors due to constrain issues. Those errors are often vague and not helpful for debugging reason. Those sqlite errors should be wrapped around with other information to expose the root cause and provide further data for debugging. Signed-off-by: Vu Dinh <vudinh@outlook.com>
|
/rerun-all |
|
/lgtm |
Many of sqlite query returns errors due to constrain issues. Those
errors are often vague and not helpful for debugging reason.
Those sqlite errors should be wrapped around with other information
to expose the root cause and provide further data for debugging.
Signed-off-by: Vu Dinh vudinh@outlook.com
Description of the change:
Motivation for the change:
Reviewer Checklist
/docs