New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provide generic mechanism to propagate global flags to render.Run operations #986
Conversation
Codecov Report
@@ Coverage Diff @@
## master #986 +/- ##
==========================================
- Coverage 52.86% 52.65% -0.22%
==========================================
Files 104 104
Lines 9467 9445 -22
==========================================
- Hits 5005 4973 -32
- Misses 3529 3539 +10
Partials 933 933
Continue to review full report at Codecov.
|
001bc80
to
48794a1
Compare
eaf14be
to
16344af
Compare
Tested:
For each, checked help output as well as successful runs. |
2eedcbe
to
6cd204b
Compare
Signed-off-by: Jordan Keister <jordan@nimblewidget.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dinhxuanvu, grokspawn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Signed-off-by: Jordan Keister jordan@nimblewidget.com
Description of the change:
Provide a generic mechanism for propagating global flags (i.e. use-http, skip-tls-verify) into any caller of alpha/render/Run().
render.Run is updated to use the passed-in options IFF render.Reg is nil, which allows us to preserve call models which provide a ready containerd registry as well as customize call models which would instantiate the registry at that time.
I attempted to break NO API which is not "real alpha" (as opposed to gradations of alpha). There is a viable backwards-compatible path for all non-veneer APIs.
Motivation for the change:
issue #931
Reviewer Checklist
/docs