applying suggestion

pkg/ansible/controller/reconcile.go

@@ -166,6 +166,7 @@ func (r *AnsibleOperatorReconciler) Reconcile(request reconcile.Request) (reconc
 
 	// iterate events from ansible, looking for the final one
 	statusEvent := eventapi.StatusJobEvent{}
+	failureMessages := eventapi.FailureMessages{}
 	for event := range result.Events() {
 		for _, eHandler := range r.EventHandlers {
 			go eHandler.Handle(ident, u, event)
@@ -182,8 +183,12 @@ func (r *AnsibleOperatorReconciler) Reconcile(request reconcile.Request) (reconc
 			}
 		}
 		if event.Event == eventapi.EventRunnerOnFailed && !event.IgnoreError() {
-			eventErr := errors.New("event runner on failed")
-			return reconcile.Result{}, eventErr
+			if len(event.GetFailedPlaybookMessage()) < 1 {
+				eventErr := fmt.Errorf("Event runner on failed (%v)", event.EventData["Task"])
+				failureMessages = append(failureMessages, eventErr.Error())
+			} else {
+				failureMessages = append(failureMessages, event.GetFailedPlaybookMessage())
+			}
 		}
 	}
 	if statusEvent.Event == "" {
@@ -210,8 +215,12 @@ func (r *AnsibleOperatorReconciler) Reconcile(request reconcile.Request) (reconc
 	// try to get the updated finalizers
 	pendingFinalizers = u.GetFinalizers()
 
+	// We only want to update the CustomResource once, so we'll track changes
+	// and do it at the end
+	runSuccessful := len(failureMessages) == 0
+
 	// The finalizer has run successfully, time to remove it
-	if deleted && finalizerExists {
+	if deleted && finalizerExists && runSuccessful {
 		finalizers := []string{}
 		for _, pendingFinalizer := range pendingFinalizers {
 			if pendingFinalizer != finalizer {
@@ -226,12 +235,17 @@ func (r *AnsibleOperatorReconciler) Reconcile(request reconcile.Request) (reconc
 		}
 	}
 	if r.ManageStatus {
-		errmark := r.markDone(u, request.NamespacedName, statusEvent, nil)
+		errmark := r.markDone(u, request.NamespacedName, statusEvent, failureMessages)
 		if errmark != nil {
 			logger.Error(errmark, "Failed to mark status done")
 		}
 		return reconcileResult, errmark
 	}
+
+	// re-trigger reconcile because of failures
+	if !runSuccessful {
+		return reconcileResult, errors.New("Event runner on failed")
+	}
 	return reconcileResult, nil
 }
 

pkg/ansible/controller/reconcile_test.go

@@ -170,7 +170,6 @@ func TestReconcile(t *testing.T) {
 					Namespace: "default",
 				},
 			},
-			// Since face an event error needs re-trigger the reconcile
 			ExpectedObject: &unstructured.Unstructured{
 				Object: map[string]interface{}{
 					"metadata": map[string]interface{}{
@@ -183,11 +182,24 @@ func TestReconcile(t *testing.T) {
 					"status": map[string]interface{}{
 						"conditions": []interface{}{
 							map[string]interface{}{
-								"status":  "True",
+								"status":  "False",
 								"type":    "Running",
 								"message": "Running reconciliation",
 								"reason":  "Running",
 							},
+							map[string]interface{}{
+								"status": "True",
+								"type":   "Failure",
+								"ansibleResult": map[string]interface{}{
+									"changed":    int64(0),
+									"failures":   int64(0),
+									"ok":         int64(0),
+									"skipped":    int64(0),
+									"completion": eventTime.Format("2006-01-02T15:04:05.99999999"),
+								},
+								"message": "new failure message",
+								"reason":  "Failed",
+							},
 						},
 					},
 				},