Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use a custom Context type #161

Closed
ericchiang opened this issue Apr 3, 2018 · 3 comments
Closed

Don't use a custom Context type #161

ericchiang opened this issue Apr 3, 2018 · 3 comments
Labels
release-blocker This issue blocks the parent release milestone

Comments

@ericchiang
Copy link

This block is particularly odd

// Context is the special context that is passed to the Handler.
// It includes:
// - Context: standard Go context that is used to pass cancellation signals and deadlines
type Context struct {
	Context context.Context
}

Are there plans to expand it? If not we should just pass additional arguments to the Handler.

@ericchiang ericchiang added release-blocker This issue blocks the parent release milestone area/api labels Apr 3, 2018
@fanminshi
Copy link
Contributor

No plans to expand it yet. I think we should just use default golang context type instead.

@ericchiang
Copy link
Author

cc @Verolop

@rithujohn191
Copy link
Contributor

#259 fixes this issue

m1kola pushed a commit to m1kola/operator-sdk that referenced this issue Jun 7, 2024
…istency-openshift-4.10-openshift-enterprise-ansible-operator

Updating openshift-enterprise-ansible-operator images to be consistent with ART
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-blocker This issue blocks the parent release milestone
Projects
None yet
Development

No branches or pull requests

3 participants