Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<operator-name>.package.yaml was not generated with 0.17.0 #2967

Closed
gyliu513 opened this issue May 5, 2020 · 8 comments
Closed

<operator-name>.package.yaml was not generated with 0.17.0 #2967

gyliu513 opened this issue May 5, 2020 · 8 comments
Assignees
Labels
lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. olm-integration Issue relates to the OLM integration triage/support Indicates an issue that is a support question.

Comments

@gyliu513
Copy link
Contributor

gyliu513 commented May 5, 2020

Bug Report

What did you do?
A clear and concise description of the steps you took (or insert a code snippet).

I used the command as follows to generate my CSV file

operator-sdk generate csv --make-manifests=false --csv-version 0.0.1 --update-crds=true

But this command does not generate <operator-name>.package.yaml

deploy/
└── olm-catalog
    └── <operator-name>
        ├── 0.0.1
        │   └── <operator-name>.v0.0.1.clusterserviceversion.yaml
        └── <operator-name>.package.yaml << This was lost

What did you expect to see?
A clear and concise description of what you expected to happen (or insert a code snippet).

What did you see instead? Under which circumstances?
A clear and concise description of what you expected to happen (or insert a code snippet).

Environment

  • operator-sdk version:
root@gyliu-dev1:~/go/src/github.ibm.com/IBMPrivateCloud/ibm-infra-management-install-operator# operator-sdk version
operator-sdk version: "v0.17.0", commit: "2fd7019f856cdb6f6618e2c3c80d15c3c79d1b6c", kubernetes version: "unknown", go version: "go1.13.10 linux/amd64"
  • go version:
  • Kubernetes version information:
  • Kubernetes cluster kind:

  • Are you writing your operator in ansible, helm, or go?

Possible Solution

Additional context
Add any other context about the problem here.

@gyliu513
Copy link
Contributor Author

gyliu513 commented May 5, 2020

@camilamacedo86 can you help? Thanks!

@gyliu513 gyliu513 changed the title <operator-name>.package.yaml was not generated with 0.17..0 <operator-name>.package.yaml was not generated with 0.17.0 May 5, 2020
@camilamacedo86
Copy link
Contributor

camilamacedo86 commented May 5, 2020

Hi @gyliu513,

We removed it from 0.17 but after discussing it better we checked that the package manifest still supported by OLM and then, we reverted the change. See: #2944. Sorry, for the inconvenient and you can use the master branch until the next release.

I am closing this as sorted out. However, please feel free to ping us to re-open if you need.

@camilamacedo86 camilamacedo86 self-assigned this May 5, 2020
@camilamacedo86 camilamacedo86 added olm-integration Issue relates to the OLM integration triage/support Indicates an issue that is a support question. labels May 5, 2020
@gyliu513
Copy link
Contributor Author

gyliu513 commented May 5, 2020

Thanks @camilamacedo86 , oops, this is a break change, we should at least provide some workaround for this, but not use master branch.

/reopen

@openshift-ci-robot
Copy link

@gyliu513: Reopened this issue.

In response to this:

Thanks @camilamacedo86 , oops, this is a break change, we should at least provide some workaround for this, but not use master branch.

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@estroz
Copy link
Member

estroz commented May 5, 2020

@gyliu513 I'll be making a patch release that reverts package manifest deprecation fairly soon. We can leave this open until then.

@gyliu513
Copy link
Contributor Author

gyliu513 commented May 6, 2020

Thanks @estroz , so you mean you want to release a patch release like 0.17.1? If so, does the new version works with the operator which was generated via 0.17.0?

For my case, my operator was generated by 0.17.0, and now I want to generate the package bundle, can I continue to use the new 0.17.1 to generate the package bundle?

Look forward to the patch release soon! ;-)

@estroz
Copy link
Member

estroz commented May 8, 2020

@gyliu513 yes v0.17.1 will work with all aspects of a v0.17.0-built project. It is worth bumping patch versions if possible.

@estroz estroz added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label May 11, 2020
@estroz
Copy link
Member

estroz commented May 16, 2020

Fixed in v0.17.1.

@estroz estroz closed this as completed May 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. olm-integration Issue relates to the OLM integration triage/support Indicates an issue that is a support question.
Projects
None yet
Development

No branches or pull requests

4 participants