pkg/{ansible,helm}/controller: cached default manager client #1047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawn-hurley
added
kind/bug
openshift-ci-robot
added
the
size/S
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
shawn-hurley
force-pushed
the
bugfix/use-cache-client
branch
from
8774d09
to
a480eee
Compare
openshift-ci-robot
added
size/M
shawn-hurley
force-pushed
the
bugfix/use-cache-client
branch
2 times, most recently
from
870a09b
to
adddc8b
Compare
openshift-ci-robot
added
the
needs-rebase
…rator-framework#1512) * *: bump code to controller-runtime v0.2.0-beta.3, helm v2.14.0, kubernetes deps v1.14.1 * doc/,CHANGELOG.md: bump docs to controller-runtime v0.2.0-beta.3, helm v2.14.0, kubernetes deps v1.14.1 * vendor/,Gopkg.lock: bump deps to controller-runtime v0.2.0-beta.3, helm v2.14.0, kubernetes deps v1.14.1
…rator-framework#1801) * internal/pkg/scaffold: update go.mod scaffolds and add github.com/prometheus/prometheus replace * internal/pkg/scaffold: remove kube-state-metrics from dep manager file scaffolds
estroz
force-pushed
the
bugfix/use-cache-client
branch
from
a037f96
to
6daa319
Compare
openshift-ci-robot
added
lgtm
estroz
force-pushed
the
bugfix/use-cache-client
branch
2 times, most recently
from
42cda48
to
ad0e58f
Compare
estroz
force-pushed
the
bugfix/use-cache-client
branch
from
ad0e58f
to
2f9b1af
Compare
|
I tested this one out on an OCP 4.2 system, seems to work, ran the e2e molecule test. /lgtm |
camilamacedo86
approved these changes
Dec 10, 2019
|
New changes are detected. LGTM label has been removed. |
estroz
changed the title
This was referenced Dec 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new default client for ansible and helm with use the cache for the
reader interface.