Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/ansible/controller: Updater api reader to use client #1054

Merged

Conversation

shawn-hurley
Copy link
Member

@shawn-hurley shawn-hurley commented Feb 4, 2019

Description of the change:
Use the API reader to get the object from API after ansible has run.
Also, to deal with changes that a user could have made during the reconciliation run, we will just requeue the object and handle. This conforms to the eventually consistent model.

Motivation for the change:
To change the case when a resource is updated by the user as we are reconciling. This means that we will stop what we are doing and requeue the update.

@shawn-hurley shawn-hurley added kind/bug Categorizes issue or PR as related to a bug. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. language/ansible Issue is related to an Ansible operator project labels Feb 4, 2019
@openshift-ci-robot openshift-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 4, 2019
@shawn-hurley shawn-hurley changed the base branch from master to v0.4.x February 4, 2019 13:02
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 4, 2019
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 4, 2019
@shawn-hurley shawn-hurley changed the title [WIP] - pkg/ansible: fix CI pkg/ansible/controller: Updater api reader to use client Feb 4, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 4, 2019
* Handle case when CR is changed while we are working on it.
  To handle this we will return and just re-run the reconcile
  this should be fine due to eventually consistent model.
Copy link
Member

@fabianvf fabianvf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shawn-hurley shawn-hurley merged commit ee9f7ad into operator-framework:v0.4.x Feb 4, 2019
shawn-hurley pushed a commit to shawn-hurley/operator-sdk that referenced this pull request Apr 23, 2019
…mework#1054)

* Handle case when CR is changed while we are working on it.
  To handle this we will return and just re-run the reconcile
  this should be fine due to eventually consistent model.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. language/ansible Issue is related to an Ansible operator project size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants