Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gen-csv: generate 'alm-examples' annotations from CR's #1116

Merged
merged 9 commits into from
Apr 3, 2019

Conversation

estroz
Copy link
Member

@estroz estroz commented Feb 20, 2019

Description of the change: update 'alm-examples' annotations with operator CR's, and remove CSV prefix from updaters (its obvious what they're updating).

Motivation for the change: further aligns generated CSV's, specifically metadata, with what OLM expects.

@estroz estroz added kind/feature Categorizes issue or PR as related to a new feature. olm-integration Issue relates to the OLM integration labels Feb 20, 2019
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 20, 2019
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 3, 2019
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 4, 2019
Copy link
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after rebase

Copy link
Member

@lilic lilic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@hasbro17
Copy link
Contributor

hasbro17 commented Apr 3, 2019

Add a line for this in the CHANGELOG. It's a useful feature worth pointing out.

@estroz estroz merged commit 6d26d94 into operator-framework:master Apr 3, 2019
@estroz estroz deleted the generate-alm-examples branch April 3, 2019 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. olm-integration Issue relates to the OLM integration size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants