Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gopkg.toml,pkg/scaffold/helm/gopkgtoml.go: bump to helm 2.13.1 #1235

Merged
merged 2 commits into from
Mar 22, 2019

Conversation

joelanford
Copy link
Member

Description of the change:
Bumps helm version to 2.13.1

Motivation for the change:
Helm 2.13.1 fixes an issue in chartutil.SaveDir() that causes operator-sdk new mychart-operator --type=helm --helm-chart=./my-chart to fail if ./mychart contains files in subdirectories of ./mychart/templates (e.g. ./mychart/templates/hooks/myhook.yaml)

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 22, 2019
Copy link
Contributor

@hasbro17 hasbro17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Might be worth adding a line to the CHANGELOG since this is technically a bugfix for us.

@joelanford joelanford merged commit b7dd823 into operator-framework:master Mar 22, 2019
@joelanford joelanford deleted the helm-bump-version branch March 22, 2019 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants