pkg/helm,hack/tests: slim down release information in Helm CR status #1309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelanford
added
kind/feature
openshift-ci-robot
added
the
size/M
With the Helm storage backend moved to in-cluster secrets, it is no longer necessary to store the full release state on the CR status. This commit removes the full release status from the status condition and adds a new "deployedRelease" field on the top level status that contains just the release name and manifest.
joelanford
force-pushed
the
helm-remove-release-state
branch
from
0f8fa22
to
c6f9a42
Compare
|
/cc @lilic @AlexNPavel @hasbro17 @estroz Please review when you get a chance 🙂 |
|
New changes are detected. LGTM label has been removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
This PR removes the full release status from the status condition and adds a new
deployedReleasefield on the top level status that contains just the release name and manifest.This PR also removes code that syncs the release state from the status condition to the storage backend, which was leftover from when the Helm operator used the in-memory backend. Now that the CR status does not contain the full release state, there is nothing to sync.
Motivation for the change:
With the Helm storage backend moved to in-cluster secrets, it is no longer necessary to store the full release state on the CR status. This change will de-clutter the CR status to make it easier for users to find what they're looking for.