Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/pkg/scaffold/resource.go: relax group format check #1313

Merged
merged 4 commits into from
Apr 16, 2019
Merged

internal/pkg/scaffold/resource.go: relax group format check #1313

merged 4 commits into from
Apr 16, 2019

Conversation

estroz
Copy link
Member

@estroz estroz commented Apr 11, 2019

Description of the change: only check if group in group/version is empty, not if it has a specific number of sub-domains.

Motivation for the change: From #1191 on adding new API's:

But I guess that only makes sense for defining new apis. If you're adding a controller to watch a k8s resource(with a single word group) as the primary resource then that'll be a problem.

Closes #1191

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 11, 2019
hasbro17
hasbro17 approved these changes Apr 11, 2019
View reviewed changes
Copy link
Contributor

@hasbro17 hasbro17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Also add a line in the CHANGELOG?

@estroz estroz merged commit 6767e9a into operator-framework:master Apr 16, 2019
@estroz estroz deleted the relax-group-check branch April 16, 2019 00:32
@philipgough philipgough mentioned this pull request Apr 23, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasbro17 hasbro17 hasbro17 approved these changes

@joelanford joelanford Awaiting requested review from joelanford

@AlexNPavel AlexNPavel Awaiting requested review from AlexNPavel

Assignees
No one assigned
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unable to generate controller for the core group
3 participants
@estroz @hasbro17 @openshift-ci-robot