fix ansible e2e #1348
Merged
fix ansible e2e #1348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estroz
added
kind/bug
openshift-ci-robot
added
the
do-not-merge/work-in-progress
openshift-ci-robot
added
the
size/S
estroz
commented
Apr 25, 2019
| @@ -51,8 +51,14 @@ RUN yum remove -y ansible python-idna | |||
| RUN yum install -y inotify-tools && yum clean all | |||
| RUN pip uninstall ansible-runner -y | |||
|
|
|||
| RUN pip install --upgrade setuptools | |||
| RUN pip install ansible ansible-runner openshift kubernetes ansible-runner-http idna==2.7 | |||
| RUN pip install --upgrade setuptools==41.0.1 | |||
There was a problem hiding this comment.
These versions are from a pip list of the latest dependencies.
pin ansible-runner and molecule versions so their 'six' dependency does not conflict
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
estroz
commented
Apr 25, 2019
| RUN yum install -y python-devel gcc libffi-devel && pip install molecule | ||
|
|
||
| RUN yum install -y python-devel gcc libffi-devel | ||
| RUN pip install molecule==2.20.1 |
estroz
commented
Apr 25, 2019
fabianvf
reviewed
Apr 25, 2019
fabianvf
reviewed
Apr 25, 2019
|
/lgtm |
shawn-hurley
approved these changes
Apr 25, 2019
|
/lgtm |
estroz
pushed a commit
to estroz/operator-sdk
that referenced
this pull request
Apr 25, 2019
* internal/pkg/scaffold/ansible/dockerfilehybrid.go: fix anisble and dependency versions * fix urllib3 so requests and kubernetes do not conflict * internal/pkg/scaffold/ansible/build_test_framework_dockerfile.go: pin ansible-runner and molecule versions so their 'six' dependency does not conflict * use ansible-runner 1.2 * use 0.8.0<=kubernetes<0.9.0 and openshift==0.8.8
estroz
pushed a commit
that referenced
this pull request
Apr 26, 2019
* fix ansible e2e (#1348) * internal/pkg/scaffold/ansible/dockerfilehybrid.go: fix anisble and dependency versions * fix urllib3 so requests and kubernetes do not conflict * internal/pkg/scaffold/ansible/build_test_framework_dockerfile.go: pin ansible-runner and molecule versions so their 'six' dependency does not conflict * use ansible-runner 1.2 * use 0.8.0<=kubernetes<0.9.0 and openshift==0.8.8 * CHANGELOG.md: bug fix entry for pinning ansible dep versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change: pin python library versions in
internal/pkg/scaffold/ansible/dockerfilehybrid.goandinternal/pkg/scaffold/ansible/build_test_framework_dockerfile.go.Motivation for the change:
urllib3version conflict betweenkubernetesandrequestssixversion conflict betweenmoleculeandansible-runner