internal/pkg/scaffold/helm/role.go: add custom rules for namespaced scope #1456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XS
|
Need to backport this to the |
joelanford
added a commit
to joelanford/operator-sdk
that referenced
this pull request
May 21, 2019
joelanford
added a commit
to joelanford/operator-sdk
that referenced
this pull request
May 21, 2019
joelanford
added a commit
to joelanford/operator-sdk
that referenced
this pull request
May 21, 2019
joelanford
added a commit
that referenced
this pull request
May 21, 2019
joelanford
added a commit
to joelanford/operator-sdk
that referenced
this pull request
May 21, 2019
joelanford
added a commit
to joelanford/operator-sdk
that referenced
this pull request
May 21, 2019
* internal/pkg/scaffold/helm/role.go: return on role generation error * internal/pkg/scaffold/helm/role.go: handle OCP k8s versions * hack/tests/e2e-helm.sh: fail on failed RBAC generation * CHANGELOG.md: added lines for fixes from operator-framework#1456 and operator-framework#1461
joelanford
added a commit
that referenced
this pull request
May 21, 2019
joelanford
added a commit
that referenced
this pull request
May 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Always add custom roles when generating Helm role rules, regardless of whether the operator is cluster-scoped or not.
Motivation for the change:
This is a regression that should be fixed. We didn't catch it in reviews and CI somehow passed for #1434.