Fix multiline boilerplates #1544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go permits multiline, block-style comments. It's common for boilerplates to utilize these for licences (e.g. Apache-2.0's standard boilerplate). This PR removes the line-by-line stripping of whitespace, and adds a test for it.
openshift-ci-robot
added
the
size/M
|
@estroz Thanks for the review. Anything else required to merge? |
|
@cblecker just waiting on more reviews. |
openshift-ci-robot
requested review from
joelanford,
lilic,
shawn-hurley and
theishshah
lilic
approved these changes
Jun 13, 2019
estroz
pushed a commit
to estroz/operator-sdk
that referenced
this pull request
Jul 17, 2019
Go permits multiline, block-style comments. It's common for boilerplates to utilize these for licences (e.g. Apache-2.0's standard boilerplate). This PR removes the line-by-line stripping of whitespace, and adds a test for it.
estroz
added a commit
to estroz/operator-sdk
that referenced
this pull request
Jul 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Go permits multiline, block-style comments. It's common for boilerplates to utilize these for licences (e.g. Apache-2.0's standard boilerplate).
This PR removes the line-by-line stripping of whitespace, and adds a test for it.
Motivation for the change:
Allow existing projects with compliant, multiline boilerplates to use them.