Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiline boilerplates #1544

Merged
merged 1 commit into from Jun 13, 2019

Conversation

@cblecker
Copy link
Contributor

commented Jun 11, 2019

Description of the change:
Go permits multiline, block-style comments. It's common for boilerplates to utilize these for licences (e.g. Apache-2.0's standard boilerplate).

This PR removes the line-by-line stripping of whitespace, and adds a test for it.

Motivation for the change:
Allow existing projects with compliant, multiline boilerplates to use them.

Fix multiline boilerplates
Go permits multiline, block-style comments. It's common for boilerplates
to utilize these for licences (e.g. Apache-2.0's standard boilerplate).

This PR removes the line-by-line stripping of whitespace, and adds a test for
it.
@estroz

estroz approved these changes Jun 11, 2019

Copy link
Member

left a comment

/lgtm

@cblecker thanks for the PR!

@cblecker

This comment has been minimized.

Copy link
Contributor Author

commented Jun 13, 2019

@estroz Thanks for the review. Anything else required to merge?

@estroz

This comment has been minimized.

Copy link
Member

commented Jun 13, 2019

@cblecker just waiting on more reviews.

/cc @joelanford @LiliC @shawn-hurley @theishshah

@LiliC

LiliC approved these changes Jun 13, 2019

Copy link
Member

left a comment

Good to know, thanks for your PR!

lgtm

@LiliC LiliC merged commit ebf771e into operator-framework:master Jun 13, 2019

4 checks passed

ci/prow/marker Job succeeded.
Details
ci/prow/sanity Job succeeded.
Details
ci/prow/unit Job succeeded.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@cblecker cblecker deleted the cblecker:fix-boilerplate-multiline branch Jun 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.