internal/pkg/scorecard: access CRManifestOpt correctly with --olm-deployed
#1565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etting and use []string when setting CRManifestOpt
estroz
added
kind/bug
estroz
requested review from
joelanford,
shawn-hurley,
AlexNPavel,
lilic,
hasbro17 and
theishshah
estroz
changed the title
CRManifestOpt correctly with --olm-deployedCRManifestOpt correctly with --olm-deployed
openshift-ci-robot
added
the
size/M
hasbro17
approved these changes
Jun 18, 2019
joelanford
reviewed
Jun 18, 2019
AlexNPavel
reviewed
Jun 19, 2019
| if err != nil { | ||
| return nil, err | ||
| } | ||
| crFile, err := ioutil.TempFile("", "*.cr.yaml") |
There was a problem hiding this comment.
Why is the file *.cr.yaml now?
There was a problem hiding this comment.
The temp file names were in an annoying format before 😁. This format uses .cr.yaml as a file extension.
estroz
pushed a commit
to estroz/operator-sdk
that referenced
this pull request
Jul 19, 2019
…deployed` (operator-framework#1565) * internal/pkg/scorecard/scorecard.go: use viper.GetStringSlice() for getting and use []string when setting CRManifestOpt * CHANGELOG.md: update with scorecard cr-manifests bug fix
This was referenced Jul 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change: use
viper.GetStringSlice()for getting and use[]stringwhen settingCRManifestOptwith--olm-deployed.Motivation for the change:
CRManifestOptis not accessed correctly when--olm-deployedis set.